[PATCH] Use definition for cmpxchg swi
nico at fluxnic.net
Mon Nov 9 14:31:23 EST 2009
On Mon, 9 Nov 2009, Jamie Lokier wrote:
> Russell King - ARM Linux wrote:
> > I'll add a comment then.
> > Note, however, that the original code was buggy - it resulted in
> > the '0xfff0' syscall being called instead of '0xffff0' - note the
> > extra 4 bits there.
> Meaning that nobody has ever actually used the original code? :-)
Hard to tell. This is certainly the last of the last resorts.
> I notice that it loads the syscall number register for EABI
> compatibility, but that instruction could be trivially omitted with
> OABI-compatible kernels, couldn't it?
Maybe, but I don't think we should care that much. This is only to
support maybe one or two dev boards in existence on the planet that
might even not be used anymore, and being the solution of last resort
means it is already much much slower than the alternatives. So this is
not worth the bother.
> By the way, did you change it to LDR to make it faster? (I.e. does
> that make it faster?)
It's most probably only a case of making the define usage simpler.
More information about the linux-arm-kernel