[PATCH] Use definition for cmpxchg swi

Jamie Lokier jamie at shareable.org
Mon Nov 9 14:08:52 EST 2009


Russell King - ARM Linux wrote:
> I'll add a comment then.
> 
> Note, however, that the original code was buggy - it resulted in
> the '0xfff0' syscall being called instead of '0xffff0' - note the
> extra 4 bits there.

Meaning that nobody has ever actually used the original code? :-)

I notice that it loads the syscall number register for EABI
compatibility, but that instruction could be trivially omitted with
OABI-compatible kernels, couldn't it?

By the way, did you change it to LDR to make it faster?  (I.e. does
that make it faster?)

-- Jamie



More information about the linux-arm-kernel mailing list