[PATCH] Use definition for cmpxchg swi

Nicolas Pitre nico at fluxnic.net
Mon Nov 9 09:56:26 EST 2009


On Mon, 9 Nov 2009, Russell King - ARM Linux wrote:

> On Sun, Nov 08, 2009 at 08:42:51PM -0500, Nicolas Pitre wrote:
> > On Sun, 8 Nov 2009, Russell King - ARM Linux wrote:
> > 
> > > Use a definition for the cmpxchg SWI instead of hard-coding the number.
> > 
> > Well...  Initially I didn't use a definition in unistd.h because I 
> > didn't want user space to "see" it and assume this was part of the 
> > kernel ABI since this is actually just an implementation detail that 
> > depends on a particular kernel configuration.
> 
> The ifdef __KERNEL__ is sufficient for that - kernel headers are now
> stripped of code within these defines during 'make installheaders'.

Sure. But I wouldn't be surprised to see people redefining it manually 
just because they didn't understand why there was a #ifdef __KERNEL__ in 
the kernel file.  Adding a comment makes the intent clearer.


Nicolas



More information about the linux-arm-kernel mailing list