[PATCH 09/17] ARM: S5PC1xx: add platform helpers for s3c-fb device

Ben Dooks ben-linux at fluff.org
Sun Nov 8 19:02:52 EST 2009


On Tue, Oct 13, 2009 at 10:11:14AM +0200, Marek Szyprowski wrote:
> Samsung S5PC100 has LCD-controller compatible with the one known from
> previous SoCs series. Add required platform setup and support code that
> it can be used with s3c-fb driver.
> 
> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski at samsung.com>
> ---
>  arch/arm/mach-s5pc100/include/mach/irqs.h    |    5 +
>  arch/arm/mach-s5pc100/include/mach/regs-fb.h |  259 ++++++++++++++++++++++++++
>  arch/arm/plat-s3c/include/plat/fb.h          |    7 +
>  arch/arm/plat-s5pc1xx/Kconfig                |    5 +
>  arch/arm/plat-s5pc1xx/Makefile               |    1 +
>  arch/arm/plat-s5pc1xx/setup-fb-24bpp.c       |   49 +++++
>  6 files changed, 326 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/mach-s5pc100/include/mach/regs-fb.h
>  create mode 100644 arch/arm/plat-s5pc1xx/setup-fb-24bpp.c
> 
> diff --git a/arch/arm/mach-s5pc100/include/mach/irqs.h b/arch/arm/mach-s5pc100/include/mach/irqs.h
> index 622720d..b53fa48 100644
> --- a/arch/arm/mach-s5pc100/include/mach/irqs.h
> +++ b/arch/arm/mach-s5pc100/include/mach/irqs.h
> @@ -11,4 +11,9 @@
>  
>  #include <plat/irqs.h>
>  
> +/* LCD */
> +#define IRQ_LCD_FIFO		IRQ_LCD0
> +#define IRQ_LCD_VSYNC		IRQ_LCD1
> +#define IRQ_LCD_SYSTEM		IRQ_LCD2
> +
>  #endif /* __ASM_ARCH_IRQ_H */
> diff --git a/arch/arm/mach-s5pc100/include/mach/regs-fb.h b/arch/arm/mach-s5pc100/include/mach/regs-fb.h
> new file mode 100644
> index 0000000..4701979
> --- /dev/null
> +++ b/arch/arm/mach-s5pc100/include/mach/regs-fb.h
> @@ -0,0 +1,259 @@
> +/* arch/arm/mach-s3c6400/include/mach/regs-fb.h
> + *
> + * Copyright 2008 Openmoko, Inc.
> + * Copyright 2008 Simtec Electronics
> + *      http://armlinux.simtec.co.uk/
> + *      Ben Dooks <ben at simtec.co.uk>

Either make the file common, or have an attribution to the original
source it was copied from. Otherwise, thanks for writing some code
and giving it to me.

PS, this seems to be a less than occasional occurance here. Whilst it
might seem flattering, the amount of crud that gets mis-attributed to
other people can often cause an ammount of annoyance. Please try to
avoid this in the future.

> + * S3C64XX - new-style framebuffer register definitions
> + *
> + * This is the register set for the new style framebuffer interface
> + * found from the S3C2443 onwards and specifically the S3C64XX series
> + * S3C6400 and S3C6410.
> + *
> + * The file contains the cpu specific items which change between whichever
> + * architecture is selected. See <plat/regs-fb.h> for the core definitions
> + * that are the same.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +/* include the core definitions here, in case we really do need to
> + * override them at a later date.
> +*/
> +
> +#include <plat/regs-fb.h>
> +
> +#define S3C_FB_MAX_WIN (5)  /* number of hardware windows available. */
> +#define VIDCON1_FSTATUS_EVEN	(1 << 15)
> +
> +/* Video timing controls */
> +#define VIDTCON0				(0x10)
> +#define VIDTCON1				(0x14)
> +#define VIDTCON2				(0x18)
> +
> +/* Window position controls */
> +
> +#define WINCON(_win)				(0x20 + ((_win) * 4))
> +
> +/* OSD1 and OSD4 do not have register D */
> +
> +#define VIDOSD_A(_win)				(0x40 + ((_win) * 16))
> +#define VIDOSD_B(_win)				(0x44 + ((_win) * 16))
> +#define VIDOSD_C(_win)				(0x48 + ((_win) * 16))
> +#define VIDOSD_D(_win)				(0x4C + ((_win) * 16))
> +
> +/* Video buffer addresses */
> +
> +#define VIDW_BUF_START(_buff)			(0xA0 + ((_buff) * 8))
> +#define VIDW_BUF_START1(_buff)			(0xA4 + ((_buff) * 8))
> +#define VIDW_BUF_END(_buff)			(0xD0 + ((_buff) * 8))
> +#define VIDW_BUF_END1(_buff)			(0xD4 + ((_buff) * 8))
> +#define VIDW_BUF_SIZE(_buff)			(0x100 + ((_buff) * 4))
> +
> +#define VIDINTCON0				(0x130)
> +
> +#define WxKEYCONy(_win, _con)			((0x140 + ((_win) * 8)) + ((_con) * 4))
> +
> +/* WINCONx */
> +
> +#define WINCONx_CSCWIDTH_MASK			(0x3 << 26)
> +#define WINCONx_CSCWIDTH_SHIFT			(26)
> +#define WINCONx_CSCWIDTH_WIDE			(0x0 << 26)
> +#define WINCONx_CSCWIDTH_NARROW			(0x3 << 26)
> +
> +#define WINCONx_ENLOCAL				(1 << 22)
> +#define WINCONx_BUFSTATUS			(1 << 21)
> +#define WINCONx_BUFSEL				(1 << 20)
> +#define WINCONx_BUFAUTOEN			(1 << 19)
> +#define WINCONx_YCbCr				(1 << 13)
> +
> +#define WINCON1_LOCALSEL_CAMIF			(1 << 23)
> +
> +#define WINCON2_LOCALSEL_CAMIF			(1 << 23)
> +#define WINCON2_BLD_PIX				(1 << 6)
> +
> +#define WINCON2_ALPHA_SEL			(1 << 1)
> +#define WINCON2_BPPMODE_MASK			(0xf << 2)
> +#define WINCON2_BPPMODE_SHIFT			(2)
> +#define WINCON2_BPPMODE_1BPP			(0x0 << 2)
> +#define WINCON2_BPPMODE_2BPP			(0x1 << 2)
> +#define WINCON2_BPPMODE_4BPP			(0x2 << 2)
> +#define WINCON2_BPPMODE_8BPP_1232		(0x4 << 2)
> +#define WINCON2_BPPMODE_16BPP_565		(0x5 << 2)
> +#define WINCON2_BPPMODE_16BPP_A1555		(0x6 << 2)
> +#define WINCON2_BPPMODE_16BPP_I1555		(0x7 << 2)
> +#define WINCON2_BPPMODE_18BPP_666		(0x8 << 2)
> +#define WINCON2_BPPMODE_18BPP_A1665		(0x9 << 2)
> +#define WINCON2_BPPMODE_19BPP_A1666		(0xa << 2)
> +#define WINCON2_BPPMODE_24BPP_888		(0xb << 2)
> +#define WINCON2_BPPMODE_24BPP_A1887		(0xc << 2)
> +#define WINCON2_BPPMODE_25BPP_A1888		(0xd << 2)
> +#define WINCON2_BPPMODE_28BPP_A4888		(0xd << 2)
> +
> +#define WINCON3_BLD_PIX				(1 << 6)
> +
> +#define WINCON3_ALPHA_SEL			(1 << 1)
> +#define WINCON3_BPPMODE_MASK			(0xf << 2)
> +#define WINCON3_BPPMODE_SHIFT			(2)
> +#define WINCON3_BPPMODE_1BPP			(0x0 << 2)
> +#define WINCON3_BPPMODE_2BPP			(0x1 << 2)
> +#define WINCON3_BPPMODE_4BPP			(0x2 << 2)
> +#define WINCON3_BPPMODE_16BPP_565		(0x5 << 2)
> +#define WINCON3_BPPMODE_16BPP_A1555		(0x6 << 2)
> +#define WINCON3_BPPMODE_16BPP_I1555		(0x7 << 2)
> +#define WINCON3_BPPMODE_18BPP_666		(0x8 << 2)
> +#define WINCON3_BPPMODE_18BPP_A1665		(0x9 << 2)
> +#define WINCON3_BPPMODE_19BPP_A1666		(0xa << 2)
> +#define WINCON3_BPPMODE_24BPP_888		(0xb << 2)
> +#define WINCON3_BPPMODE_24BPP_A1887		(0xc << 2)
> +#define WINCON3_BPPMODE_25BPP_A1888		(0xd << 2)
> +#define WINCON3_BPPMODE_28BPP_A4888		(0xd << 2)
> +
> +#define VIDINTCON0_FIFIOSEL_WINDOW2		(0x10 << 5)
> +#define VIDINTCON0_FIFIOSEL_WINDOW3		(0x20 << 5)
> +#define VIDINTCON0_FIFIOSEL_WINDOW4		(0x40 << 5)
> +
> +#define DITHMODE				(0x170)
> +#define WINxMAP(_win)				(0x180 + ((_win) * 4))
> +
> +
> +#define DITHMODE_R_POS_MASK			(0x3 << 5)
> +#define DITHMODE_R_POS_SHIFT			(5)
> +#define DITHMODE_R_POS_8BIT			(0x0 << 5)
> +#define DITHMODE_R_POS_6BIT			(0x1 << 5)
> +#define DITHMODE_R_POS_5BIT			(0x2 << 5)
> +
> +#define DITHMODE_G_POS_MASK			(0x3 << 3)
> +#define DITHMODE_G_POS_SHIFT			(3)
> +#define DITHMODE_G_POS_8BIT			(0x0 << 3)
> +#define DITHMODE_G_POS_6BIT			(0x1 << 3)
> +#define DITHMODE_G_POS_5BIT			(0x2 << 3)
> +
> +#define DITHMODE_B_POS_MASK			(0x3 << 1)
> +#define DITHMODE_B_POS_SHIFT			(1)
> +#define DITHMODE_B_POS_8BIT			(0x0 << 1)
> +#define DITHMODE_B_POS_6BIT			(0x1 << 1)
> +#define DITHMODE_B_POS_5BIT			(0x2 << 1)
> +
> +#define DITHMODE_DITH_EN			(1 << 0)
> +
> +#define WPALCON					(0x1A0)
> +
> +#define WPALCON_W4PAL_16BPP_A555		(1 << 8)
> +#define WPALCON_W3PAL_16BPP_A555		(1 << 7)
> +#define WPALCON_W2PAL_16BPP_A555		(1 << 6)
> +
> +/* Palette registers */
> +
> +#define WIN2_PAL(_entry)			(0x300 + ((_entry) * 2))
> +#define WIN3_PAL(_entry)			(0x320 + ((_entry) * 2))
> +#define WIN4_PAL(_entry)			(0x340 + ((_entry) * 2))
> +#define WIN0_PAL(_entry)			(0x400 + ((_entry) * 4))
> +#define WIN1_PAL(_entry)			(0x800 + ((_entry) * 4))
> +
> +/* system specific implementation code for palette sizes, and other
> + * information that changes depending on which architecture is being
> + * compiled.
> +*/
> +
> +/* return true if window _win has OSD register D */
> +#define s3c_fb_has_osd_d(_win) ((_win) != 4 && (_win) != 0)
> +
> +static inline unsigned int s3c_fb_win_pal_size(unsigned int win)
> +{
> +	if (win < 2)
> +		return 256;
> +	if (win < 4)
> +		return 16;
> +	if (win == 4)
> +		return 4;
> +
> +	BUG();	/* shouldn't get here */
> +}
> +
> +static inline int s3c_fb_validate_win_bpp(unsigned int win, unsigned int bpp)
> +{
> +	/* all windows can do 1/2 bpp */
> +
> +	if ((bpp == 25 || bpp == 19) && win == 0)
> +		return 0;	/* win 0 does not have 19 or 25bpp modes */
> +
> +	if (bpp == 4 && win == 4)
> +		return 0;
> +
> +	if (bpp == 8 && (win >= 3))
> +		return 0;	/* win 3/4 cannot do 8bpp in any mode */
> +
> +	return 1;
> +}
> +
> +static inline unsigned int s3c_fb_pal_reg(unsigned int window, int reg)
> +{
> +	switch (window) {
> +	case 0: return WIN0_PAL(reg);
> +	case 1: return WIN1_PAL(reg);
> +	case 2: return WIN2_PAL(reg);
> +	case 3: return WIN3_PAL(reg);
> +	case 4: return WIN4_PAL(reg);
> +	}
> +
> +	BUG();
> +}
> +
> +static inline int s3c_fb_pal_is16(unsigned int window)
> +{
> +	return window > 1;
> +}
> +
> +struct s3c_fb_palette {
> +	struct fb_bitfield	r;
> +	struct fb_bitfield	g;
> +	struct fb_bitfield	b;
> +	struct fb_bitfield	a;
> +};
> +
> +static inline void s3c_fb_init_palette(unsigned int window,
> +				       struct s3c_fb_palette *palette)
> +{
> +	if (window < 2) {
> +		/* Windows 0/1 are 8/8/8 or A/8/8/8 */
> +		palette->r.offset = 16;
> +		palette->r.length = 8;
> +		palette->g.offset = 8;
> +		palette->g.length = 8;
> +		palette->b.offset = 0;
> +		palette->b.length = 8;
> +	} else {
> +		/* currently we assume RGB 5/6/5 */
> +		palette->r.offset = 11;
> +		palette->r.length = 5;
> +		palette->g.offset = 5;
> +		palette->g.length = 6;
> +		palette->b.offset = 0;
> +		palette->b.length = 5;
> +	}
> +}
> +
> +/* Notes on per-window bpp settings
> + *
> + * Value	Win0	 Win1	  Win2	   Win3	    Win 4
> + * 0000		1(P)	 1(P)	  1(P)	   1(P)	    1(P)
> + * 0001		2(P)	 2(P)     2(P)	   2(P)	    2(P)
> + * 0010		4(P)	 4(P)     4(P)	   4(P)     -none-
> + * 0011		8(P)	 8(P)     -none-   -none-   -none-
> + * 0100		-none-	 8(A232)  8(A232)  -none-   -none-
> + * 0101		16(565)	 16(565)  16(565)  16(565)   16(565)
> + * 0110		-none-	 16(A555) 16(A555) 16(A555)  16(A555)
> + * 0111		16(I555) 16(I565) 16(I555) 16(I555)  16(I555)
> + * 1000		18(666)	 18(666)  18(666)  18(666)   18(666)
> + * 1001		-none-	 18(A665) 18(A665) 18(A665)  16(A665)
> + * 1010		-none-	 19(A666) 19(A666) 19(A666)  19(A666)
> + * 1011		24(888)	 24(888)  24(888)  24(888)   24(888)
> + * 1100		-none-	 24(A887) 24(A887) 24(A887)  24(A887)
> + * 1101		-none-	 25(A888) 25(A888) 25(A888)  25(A888)
> + * 1110		-none-	 -none-	  -none-   -none-    -none-
> + * 1111		-none-	 -none-   -none-   -none-    -none-
> +*/
> diff --git a/arch/arm/plat-s3c/include/plat/fb.h b/arch/arm/plat-s3c/include/plat/fb.h
> index 214ff56..f8db879 100644
> --- a/arch/arm/plat-s3c/include/plat/fb.h
> +++ b/arch/arm/plat-s3c/include/plat/fb.h
> @@ -70,4 +70,11 @@ extern void s3c_fb_set_platdata(struct s3c_fb_platdata *pd);
>   */
>  extern void s3c64xx_fb_gpio_setup_24bpp(void);
>  
> +/**
> + * s5pc100_fb_gpio_setup_24bpp() - S5PC100 setup function for 24bpp LCD
> + *
> + * Initialise the GPIO for an 24bpp LCD display on the RGB interface.
> + */
> +extern void s5pc100_fb_gpio_setup_24bpp(void);
> +
>  #endif /* __PLAT_S3C_FB_H */
> diff --git a/arch/arm/plat-s5pc1xx/Kconfig b/arch/arm/plat-s5pc1xx/Kconfig
> index 86edd27..6ac48a6 100644
> --- a/arch/arm/plat-s5pc1xx/Kconfig
> +++ b/arch/arm/plat-s5pc1xx/Kconfig
> @@ -37,6 +37,11 @@ config CPU_S5PC100_CLOCK
>  
>  # platform specific device setup
>  
> +config S5PC1XX_SETUP_FB_24BPP
> +	bool
> +	help
> +          Common setup code for S5PC1XX with an 24bpp RGB display helper.
> +
>  config S5PC100_SETUP_I2C0
>  	bool
>  	default y
> diff --git a/arch/arm/plat-s5pc1xx/Makefile b/arch/arm/plat-s5pc1xx/Makefile
> index f126951..34c8da5 100644
> --- a/arch/arm/plat-s5pc1xx/Makefile
> +++ b/arch/arm/plat-s5pc1xx/Makefile
> @@ -24,5 +24,6 @@ obj-$(CONFIG_CPU_S5PC100_CLOCK)	+= s5pc100-clock.o
>  
>  # Device setup
>  
> +obj-$(CONFIG_S5PC1XX_SETUP_FB_24BPP) += setup-fb-24bpp.o
>  obj-$(CONFIG_S5PC100_SETUP_I2C0) += setup-i2c0.o
>  obj-$(CONFIG_S5PC100_SETUP_I2C1) += setup-i2c1.o
> diff --git a/arch/arm/plat-s5pc1xx/setup-fb-24bpp.c b/arch/arm/plat-s5pc1xx/setup-fb-24bpp.c
> new file mode 100644
> index 0000000..b63f33e
> --- /dev/null
> +++ b/arch/arm/plat-s5pc1xx/setup-fb-24bpp.c
> @@ -0,0 +1,49 @@
> +/*
> + * linux/arch/arm/plat-s5pc100/setup-fb-24bpp.c
> + *
> + * Copyright 2009 Samsung Electronics
> + *
> + * Base S5PC1XX setup information for 24bpp LCD framebuffer
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/types.h>
> +#include <linux/fb.h>
> +
> +#include <mach/regs-fb.h>
> +#include <mach/gpio.h>
> +#include <mach/map.h>
> +#include <plat/fb.h>
> +#include <plat/gpio-cfg.h>
> +#include <plat/gpio-cfg-s5pc1xx.h>
> +
> +#define DISR_OFFSET	0x7008
> +
> +void s5pc100_fb_gpio_setup_24bpp(void)
> +{
> +	unsigned int gpio = 0;
> +
> +	for (gpio = S5PC100_GPF0(0); gpio <= S5PC100_GPF0(7); gpio++) {
> +		s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(2));
> +		s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
> +	}
> +
> +	for (gpio = S5PC100_GPF1(0); gpio <= S5PC100_GPF1(7); gpio++) {
> +		s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(2));
> +		s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
> +	}
> +
> +	for (gpio = S5PC100_GPF2(0); gpio <= S5PC100_GPF2(7); gpio++) {
> +		s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(2));
> +		s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
> +	}
> +
> +	for (gpio = S5PC100_GPF3(0); gpio <= S5PC100_GPF3(3); gpio++) {
> +		s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(2));
> +		s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
> +	}
> +}
> -- 
> 1.6.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.




More information about the linux-arm-kernel mailing list