[PATCH RFC 1/2] MUSB: CPPI 4.1 DMA driver (take 4)

Gupta, Ajay Kumar ajay.gupta at ti.com
Thu Nov 5 22:45:56 EST 2009


> > 3. linking_ram - cppi41_queue_mgr_init() seems to be the only user.  I
> >    don't see why linking_ram would be necessary.
> >
> > 4. debugging printks via pr_debug() please (and define DEBUG at the top
> of
> >    the file to enable debugging.)
> 
> Thanks for the review and valuable comments.
> 
> As we have to change the current implementation in accordance with
> standard DMA APIs, we will take above comments and post it in next RFC.

Sergei,

Any comment on this?  

Regards,
Ajay

> > > > If it's a USB DMA device (from the patches I can find, that seems to
> > be
> > > > the case) then why can't it live in drivers/usb or drivers/dma ?
> > >
> > > CPPI4.1 DMA engine can be used either by USB or by Ethernet interface
> > though
> > > currently only USB is using it but in future even Ethernet devices may
> > use it.
> >
> > drivers/dma does seem to be the right place for this.
> 
> _______________________________________________
> Davinci-linux-open-source mailing list
> Davinci-linux-open-source at linux.davincidsp.com
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source



More information about the linux-arm-kernel mailing list