[PATCH 09/17] ARM: S5PC1xx: add platform helpers for s3c-fb device

[Harald Welte]

On Tue, Oct 13, 2009 at 10:11:14AM +0200, Marek Szyprowski wrote:
> Samsung S5PC100 has LCD-controller compatible with the one known from
> previous SoCs series. Add required platform setup and support code that
> it can be used with s3c-fb driver.

Once again i like teh idea and purpose of the patch.

However, I don't like that we copy an entire header file and now have two
copies of the same header file in the kernel tree.

>  arch/arm/mach-s5pc100/include/mach/regs-fb.h |  259 ++++++++++++++++++++++++++

I'm quite sure that there must be a solution where we can avoid copying the
file to two places.

-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)