[PATCH 2/3] ARM: MXC: mxcmmc: Fix max_seg_size assignment
Daniel Mack
daniel at caiaq.de
Thu Nov 5 19:11:54 EST 2009
On Thu, Nov 05, 2009 at 05:32:51PM +0000, Russell King - ARM Linux wrote:
> Err "fix" ? No, that's not what this is.
>
> max_seg_size is the maximum segment size, not the maximum request size.
> The naming of these comes from the block IO subsystem, so it's a good
> idea to preserve the naming (and therefore the meaning.)
>
> max_req_size suggests that this parameter indicates the maximum size
> of any single request. A single request can be made up of multiple
> segments, so clearly this change is misleading.
Well - I considered that a typo only, as the left and right side were
identical:
> > - mmc->max_seg_size = mmc->max_seg_size;
Other drivers define seg_size = reg_size, and I thought that was what
was intended here.
Daniel
More information about the linux-arm-kernel
mailing list