[CFT:PATCH] Remove a seemingly unnecessary cache flush
mikpe at it.uu.se
Sun Dec 20 14:32:27 EST 2009
Mikael Pettersson writes:
> Russell King - ARM Linux writes:
> > On Mon, Dec 14, 2009 at 12:50:11PM +0100, Mikael Pettersson wrote:
> > > Russell King - ARM Linux writes:
> > > > On Mon, Dec 07, 2009 at 10:12:10PM +0000, Russell King - ARM Linux wrote:
> > > > > While looking into the possible msync() issue (which turned out to be a
> > > > > non-issue - it's covered by clever code), I found that we're flushing
> > > > > the same page multiple times.
> > > >
> > > > I'm going to queue this patch up today since I believe it is correct,
> > > > though it would be nice to have a few more people test it on pre-ARMv6
> > > > hardware.
> > >
> > > Tested here with gcc and glibc builds and testsuite runs on IXP420,
> > > IOP80219, and Kirkwood (Feroceon?), all ARMv5TE. No signs of problems.
> > Do the builds appear to be any faster?
> I didn't record how long it took because I was mainly interested in
> the correctness aspect. I can do a pair of properly measured gcc
> builds on the fastest machine next weekend.
On my Kirkwood (1.2GHz QNAP TS-119) the time to do a gcc-4.4 bootstrap
(all default languages) and testsuite run is 87561 seconds with a
vanilla 2.6.32 kernel and 86719 seconds when this patch is applied.
That's a 1% improvement.
Tested-by: Mikael Pettersson <mikpe at it.uu.se>
More information about the linux-arm-kernel