[PATCH 6/7] ARM: S5P6440: Add Board and configuration file

Russell King - ARM Linux linux at arm.linux.org.uk
Fri Dec 18 10:04:25 EST 2009


On Fri, Dec 18, 2009 at 03:57:11PM +0100, Marc Zyngier wrote:
> On Fri, 18 Dec 2009 18:19:53 +0900
> Kukjin Kim <kgene.kim at samsung.com> wrote:
> > +
> > +#include <mach/hardware.h>
> > +#include <mach/map.h>
> > +
> > +#include <asm/irq.h>
> 
> Please don't directly include asm/irq.h. Use linux/irq.h instead.

That's one of the exceptions to the "use linux/foo.h instead of asm/foo.h"
rule.

Code is fine as is.



More information about the linux-arm-kernel mailing list