[PATCH 3/4] fec: add support for Freescale i.MX25 PDK (3DS)

[Baruch Siach]

Hi Greg,

On Tue, Dec 15, 2009 at 09:52:24PM +1000, Greg Ungerer wrote:
> On 12/15/2009 06:31 PM, Baruch Siach wrote:

[snip]

> >+#ifndef CONFIG_M5272
> 
> I would suggest making this conditional on FEC_MIIGSK_ENR.
> Although the CONFIG_M5272 is the only case here currently,
> that may change over the years. And using this here may not
> be obvious to the causual code reader, since the register
> offset definitions don't explicitly key on CONFIG_M5272.

OK, I'll change this conditional.

Can I take this as an Ack from you?

baruch

> 
> >+	if (fep->phy_interface == PHY_INTERFACE_MODE_RMII) {
> >+		/* disable the gasket and wait */
> >+		writel(0, fep->hwp + FEC_MIIGSK_ENR);
> >+		while (readl(fep->hwp + FEC_MIIGSK_ENR)&  4)
> >+			udelay(1);
> >+
> >+		/* configure the gasket: RMII, 50 MHz, no loopback, no echo */
> >+		writel(1, fep->hwp + FEC_MIIGSK_CFGR);
> >+
> >+		/* re-enable the gasket */
> >+		writel(2, fep->hwp + FEC_MIIGSK_ENR);
> >+	}
> >+#endif

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -