[PATCH V2] Driver for the watchdog timer on all Freescale IMX processors.

[Wim Van Sebroeck]

Hi All,

> Changes since my V1:
> 
> * Use NULL instead of string in clk_get
> 
> Changes since the last version from Darius:
> 
> * removed all #ifdef CONFIG_ARCH_* and handle the differences at runtime
> * simplified house-keeping of the timeout value and fixed the conversion
>   into the corresponding register value
> * removed a superfluous static platform-device
> * removed debug output and comments with (IMHO) little information
> * cleaned up #includes
> * fixed some typos & removed unnecessary tabs & added kernel coding style
> * probably something else...

Some general feedback first:
* The MX2 and MX3 series have a watchdog device that cannot be stopped once
started. Since we use /dev/watchdog to start and stop the hardware, we
normally introduce a timer to keep the watchdog alive when /dev/watchdog
is closed. This is missing in this driver.
(See drivers/watchdog/at91sam9_wdt.c as an example).
* The MX1 platform is 32 bit instead of 16 bit and can be stopped and started.
Maybe it would make sense to split this in 2 drivers (one for MX1 and one for
the others).

Kind regards,
Wim.