[PATCH 4/4] MXC: imx31pdk: Trying to enabling regulators on mc13783

[Mark Brown]

On Thu, Dec 10, 2009 at 07:56:44PM +0100, Alberto Panizzo wrote:

> +/* MC13783 */
> +#define mV_to_uV(mV) (mV * 1000)

Define this somewhere global, it's generally useful.

> +
> +static struct regulator_consumer_supply gpo_consumers[] = {
> +	{
> +		.supply = "REGU_GPO1",
> +	}

What's this supply for?  Normally a supply should be specific to a
device.

> +static struct regulator_init_data gpo1_init = {
> +	.constraints = {
> +		.boot_on = 1, /* Enable it! */

I suspect you'll want always_on there - otherwise the regulator might
get switched off underneath you if the regulator core changes to make
regulator_has_full_constraints() the default.

> +static struct regulator_init_data violo_init = {
> +	.constraints = {
> +		.min_uV = mV_to_uV(1200), /* mc13783 allows min of 1200. */
> +		.max_uV = mV_to_uV(1800), /* mc13783 allows max of 1800. */

The constraints would normally be derived from the board - if none of
them want to adjust the voltage then there should be at most one voltage
specified (the voltage the system should use).