[PATCH V2 07/09] led: enable led in 88pm860x

Haojian Zhuang haojian.zhuang at gmail.com
Wed Dec 9 22:57:59 EST 2009


On Wed, Dec 9, 2009 at 10:14 AM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Wed, Dec 09, 2009 at 08:16:21AM -0500, Haojian Zhuang wrote:
>
>> +     period = on + *delay_off;
>> +     if (period < LED_BLINK_PERIOD_MIN)
>> +             period = LED_BLINK_PERIOD_MIN;
>> +     if (period > LED_BLINK_PERIOD_MAX)
>> +             period = LED_BLINK_PERIOD_MAX;
>
> If the hardware can't support the blink settings requested the driver
> ought to return an error - there's a software fallback which will blink
> the LED using a timer instead.
>

Now return an error directly.

Thanks
Haojian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-led-enable-led-in-88pm860x.patch
Type: text/x-patch
Size: 10021 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20091209/a660e74a/attachment.bin>


More information about the linux-arm-kernel mailing list