[PATCH] mmc: pxamci: call mmc_remove_host() before freeing resources

Eric Miao eric.y.miao at gmail.com
Wed Dec 2 10:02:55 EST 2009


On Wed, Dec 2, 2009 at 7:03 PM, Daniel Mack <daniel at caiaq.de> wrote:
> On Wed, Dec 02, 2009 at 08:50:44AM +0800, Eric Miao wrote:
>> On Wed, Dec 2, 2009 at 1:17 AM, Daniel Mack <daniel at caiaq.de> wrote:
>> > mmc_remove_host() will cause the mmc core to switch off the bus power by
>> > eventually calling pxamci_set_ios(). This function uses the regulator or
>> > the GPIO which have been freed already.
>> >
>> > This causes the following Oops on module unload.
>> >
>
> [...]
>
>> >
>> > Signed-off-by: Daniel Mack <daniel at caiaq.de>
>> > Reported-by: Sven Neumann <s.neumann at raumfeld.com>
>> > Cc: Pierre Ossman <pierre at ossman.eu>
>> > Cc: Eric Miao <eric.y.miao at gmail.com>
>> > Cc: linux-mmc at vger.kernel.org
>> > Cc: linux-arm-kernel at lists.infradead.org
>> > Cc: stable at kernel.org
>> > ---
>> >  drivers/mmc/host/pxamci.c |    4 ++--
>>
>> Looks like a correct fix to me.
>>
>> Acked-by: Eric Miao <eric.y.miao at gmail.com>
>
> Would be good to still get this into .32 - who will take care of picking
> this?
>

I'll send a pull request, and see if Russell will be happy to send
another one in such a short time :)



More information about the linux-arm-kernel mailing list