[PATCH 4/5] PalmGSM: generalisation of Treo680 code to PalmGSM

[Tomáš 'Sleep_Walker' Čech]

Hi,

Dne Čt 27. srpna 2009 04:31:42 Eric Miao napsal(a):
> 
> On Thu, 27 Aug 2009, Tomáš Čech wrote:
> 
> > From: Tomáš Čech <sleep walker at suse.cz>
> >
> > ---
> > arch/arm/mach-pxa/Kconfig                |    5 +
> > arch/arm/mach-pxa/Makefile               |    2 +-
> > arch/arm/mach-pxa/include/mach/palmgsm.h |   60 ++++
> > arch/arm/mach-pxa/include/mach/treo680.h |   49 ---
> > arch/arm/mach-pxa/palmgsm.c              |  559 ++++++++++++++++++++++++++++++
> > arch/arm/mach-pxa/treo680.c              |  528 ----------------------------
> 
> I don't actually care too much about the naming - as long as 685 can stay 
> within treo680.c, I don't see any problem with that. The real question is:
> is palmgsm.c the proper name for all these devices?

Well, actually your completely right. PalmGSM is not fitting for all devices to come, more fitting would be something like Palm smartphones because there are CDMA devices to come too. On the other hand, this name is the best I found so far. If you don't mind I would even so...

> And you may want to try the switch '-M' in 'git format-patch' or 'git 
> diff'.

Ah, right, thanks.

Best regards,

Tomas Cech