[PATCH 1/2 v2] ARM: OMAP4: Fix NULL pointer dereference crash.

Shilimkar, Santosh santosh.shilimkar at ti.com
Mon Aug 24 08:26:00 EDT 2009


> >>  static inline unsigned int serial_read_reg(struct plat_serial8250_port
> *up,
> >>  					   int offset)
> >>  {
> >> @@ -550,6 +564,17 @@ static struct omap_uart_state
> omap_uart[OMAP_MAX_NR_PORTS] = {
> >>  			},
> >>  		},
> >>  	},
> >> +#ifdef CONFIG_ARCH_OMAP4
> >> +	{
> >> +		.pdev = {
> >> +			.name			= "serial8250",
> >> +			.id			= PLAT8250_DEV_FOURPORT,
> >
> > This should not be FOURPORT, it should just be a number.  In this case,
> > it should be 3 (the others start from zero.)
> 
> Santosh,
> 
> I've changed the .id field to '3' and will queue up this fix for the
> next merge window along with my fixes queue[1].  Please let me know if you
> want to do otherwise.

This is fine Kevin. Thanks !!

Bye the way I have also posted v3 version in which I changed the .id field to 3.

Regards,
Santosh



More information about the linux-arm-kernel mailing list