[PATCH 3/3] thermal/drivers/amlogic: do not log the secure monitor deferral as an error

christian.koever-draxl at student.uibk.ac.at christian.koever-draxl at student.uibk.ac.at
Sun Oct 25 12:22:44 PDT 2026


From: Christian Stefan Kövér-Draxl <ckoever at outlook.de>

The thermal sensor usually probes before the secure monitor, so the
first attempt always defers and logs "Failed to get secure monitor
firmware" as an error on every boot, although the second attempt
succeeds. Use dev_err_probe(), which records the reason for the
deferral instead of logging it.

Signed-off-by: Christian Stefan Kövér-Draxl <ckoever at outlook.de>
---
 drivers/thermal/amlogic_thermal.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c
index c58bac633bed..54e59f444d46 100644
--- a/drivers/thermal/amlogic_thermal.c
+++ b/drivers/thermal/amlogic_thermal.c
@@ -196,10 +196,9 @@ static int amlogic_thermal_probe_sm(struct platform_device *pdev,
 
 	pdata->sm_fw = meson_sm_get(ph_args.np);
 	of_node_put(ph_args.np);
-	if (!pdata->sm_fw) {
-		dev_err(dev, "Failed to get secure monitor firmware\n");
-		return -EPROBE_DEFER;
-	}
+	if (!pdata->sm_fw)
+		return dev_err_probe(dev, -EPROBE_DEFER,
+				     "Failed to get secure monitor firmware\n");
 
 	pdata->tsensor_id = ph_args.args[0];
 
-- 
2.56.0




More information about the linux-amlogic mailing list