[PATCH] dma: amlogic: Fix little-endian variable operations issue
Xianwei Zhao
xianwei.zhao at amlogic.com
Mon Oct 12 19:53:47 PDT 2026
Hi Frank,
Thanks for your review.
On 2026/10/13 00:22, Frank Li wrote:
> [????????? frank.li at oss.nxp.com ????????? https://aka.ms/LearnAboutSenderIdentification?????????????]
>
> [ EXTERNAL EMAIL ]
>
> On Mon, Oct 12, 2026 at 08:00:20AM +0000, Xianwei Zhao via B4 Relay wrote:
>> From: Xianwei Zhao <xianwei.zhao at amlogic.com>
>>
>
> Subject:
> s/dma/dmaengine
>
>
Will do, I forgot it.
>> In dma_async_tx_descriptor function,fix the situation where the operation
>> processing of the little-endian variable requires corresponding conversion.
>>
>> Reported-by: kernel test robot <lkp at intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202610060235.PuCxWQdk-lkp@intel.com/
>> Fixes: b84b5197e344 ("dmaengine: amlogic: Add general DMA driver for A9")
>> Signed-off-by: Xianwei Zhao <xianwei.zhao at amlogic.com>
>> ---
>> Fix the operation little-endian variable issue.
>> ---
>> drivers/dma/amlogic-dma.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/amlogic-dma.c b/drivers/dma/amlogic-dma.c
>> index 78ee2337ae71..bbf5ae5ac705 100644
>> --- a/drivers/dma/amlogic-dma.c
>> +++ b/drivers/dma/amlogic-dma.c
>> @@ -321,7 +321,7 @@ static struct dma_async_tx_descriptor *aml_dma_prep_slave_sg
>>
>> /* the last sg set eoc flag */
>> sg_link--;
>> - sg_link->ctl |= LINK_EOC;
>> + sg_link->ctl = cpu_to_le32(le32_to_cpu(sg_link->ctl) | LINK_EOC);
>
> Does it works
>
> sg_link->ctl |= cpu_to_le32(LINK_EOC);
>
Here it is equivalent. Will do.
> Frank
>>
>> return vchan_tx_prep(&aml_chan->vchan, &aml_desc->vd, flags);
>> }
>>
>> ---
>> base-commit: 42c31fec1ca76b8b5f7759def122d418dff2cd4b
>> change-id: 20261012-fix-a9-dma-4be7e61ba653
>>
>> Best regards,
>> --
>> Xianwei Zhao <xianwei.zhao at amlogic.com>
>>
>>
More information about the linux-amlogic
mailing list