[PATCH v3 2/8] dt-bindings: net: amlogic,meson-dwmac: add amlogic,t7-dwmac

Lucas Tanure tanure at linux.com
Sun Oct 11 07:21:32 PDT 2026


On Sat, Oct 10, 2026 at 11:14 PM Martin Blumenstingl
<martin.blumenstingl at googlemail.com> wrote:
>
> Hi Lucas,
>
> On Sat, Oct 10, 2026 at 12:59 PM Lucas Tanure <tanure at linux.com> wrote:
> [...]
> > +        # The TX delay is a quarter of the RGMII clock period per step,
> > +        # which is 2ns at 1Gbit/s.
> > +        tx-internal-delay-ps:
> > +          enum: [0, 2000, 4000, 6000]
> > +          default: 0
> Is 0 a valid value? Let's say we have:
>     phy-mode = "rgmii-id";
>     tx-internal-delay-ps = <0>
>     rx-internal-delay-ps = <0>;
> According to patch 8 this means: MAC is responsible for adding the
> delays - but it doesn't add any delays.
> I'm not sure if this patch (removing 0 from the enum) or patch 8 need updating.
Yes, you are right. I will remove 0 as a valid value in v4.

Thanks
Lucas
>
>
> Best regards,
> Martin



More information about the linux-amlogic mailing list