[PATCH] arm64: dts: amlogic: meson-sm1-odroid-hc4: add the fan tachometer

[sashiko-bot at kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: amlogic: missing pinctrl for fan tachometer interrupt
--

commit a6a97db21df93ac09c2154310040802278dbb495
Author: Igor Velkov <iav at iav.lv>

arm64: dts: amlogic: meson-sm1-odroid-hc4: add the fan tachometer

This commit adds the interrupt configuration for the fan tachometer to the
pwm-fan node on the ODROID-HC4, mapping it to GPIOX_7.

> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> index 5f15c2299509b..261a42560a5e9 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> @@ -21,6 +21,8 @@ fan0: pwm-fan {
>  		#cooling-cells = <2>;
>  		cooling-levels = <0 120 170 220>;
>  		pwms = <&pwm_cd 1 40000 0>;
> +		interrupt-parent = <&gpio_intc>;
> +		interrupts = <IRQID_GPIOX_7 IRQ_TYPE_EDGE_FALLING>;

[Severity: Medium]
Does this configuration leave the hardware pin direction entirely dependent on
the pre-kernel bootloader state?

The pwm-fan driver requests the IRQ via devm_request_irq(), and the
meson-gpio-intc interrupt controller does not implement .irq_request_resources
to automatically mux the pin to GPIO mode.

Without an explicit pinctrl-0 property in the fan0 node, will the fan
tachometer silently fail to read the fan speed (always reporting 0) on systems
where the bootloader leaves GPIOX_7 configured as an alternate function (such
as uart_b_rx or pwm_f_x) instead of a GPIO input?

>  	};
>  
>  	leds {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261006-hc4-fan-tach-v1-1-4e7cecf0b45b@iav.lv?part=1