[PATCH v4 4/7] net: stmmac: dwmac-meson8b: follow the generic RGMII delay rules on the T7

Lucas Tanure tanure at linux.com
Tue Nov 3 08:31:58 PST 2026


On Sun, Nov 1, 2026 at 10:58 PM Martin Blumenstingl
<martin.blumenstingl at googlemail.com> wrote:
>
> On Thu, Oct 22, 2026 at 10:06 PM Lucas Tanure <tanure at linux.com> wrote:
> [...]
> > +       if (!dwmac->data->init_delays)
> > +               return dev_err_probe(dwmac->dev, -EINVAL,
> > +                                    "missing init_delays callback\n");
> I'd rather let this crash hard to make it obvious to someone adding a
> new SoC that they forgot something.

OK, the NULL check is gone in v5.

> Other than that this looks good.
> It would be great if the netdev maintainers could comment on whether
> this now matches the approach they had in mind.



More information about the linux-amlogic mailing list