[PATCH 1/3] arm64: dts: amlogic: meson-axg: Add missing nand_rb0 pin to nand_all_pins
sashiko-bot at kernel.org
sashiko-bot at kernel.org
Fri May 29 07:27:47 PDT 2026
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] eMMC boot failure due to BOOT_13 pinctrl conflict. Fix: Add status = "disabled" to the nfc node in meson-axg.dtsi.
--
commit c218ae59948e8bab6c68fcfdc539ef678ec3bdba
Author: Jun Yan <jerrysteve1101 at gmail.com>
arm64: dts: amlogic: meson-axg: Add missing nand_rb0 pin to nand_all_pins
This commit updates the nand_all_pins pinctrl node to include the missing
nand_rb0 pin for the meson-axg platform. This ensures the ready/busy pin
is properly configured for NAND controller operation.
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index f1f53fd98ae25..b7a7f4fae7dc2 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
[ ... ]
> @@ -481,7 +481,8 @@ mux {
> "nand_ale",
> "nand_cle",
> "nand_wen_clk",
> - "nand_ren_wr";
> + "nand_ren_wr",
> + "nand_rb0";
[Severity: High]
This isn't a bug introduced by this patch, but adding this pin exposes a
pre-existing issue where the nfc node unconditionally claims nand_all_pins.
Since nand_rb0 and emmc_ds share the BOOT_13 pin, does this force a strict
pinctrl collision between the NAND and eMMC nodes?
If this collision causes the eMMC storage probe to fail and breaks the boot
process, should we add status = "disabled" to the nfc node in meson-axg.dtsi
to prevent this conflict when NAND is not actively used?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260529140605.1070764-1-jerrysteve1101@gmail.com?part=1
More information about the linux-amlogic
mailing list