[PATCH 1/2] dt-bindings: thermal: amlogic: Add A9 thermal bindings
sashiko-bot at kernel.org
sashiko-bot at kernel.org
Thu Jul 30 01:39:49 PDT 2026
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Typo in the YAML schema `else` block: `clocks-names: false` instead of `clock-names: false` fails to forbid the property for non-A9 devices.
--
--- Patch [1]: [PATCH 1/2] dt-bindings: thermal: amlogic: Add A9 thermal bindings ---
commit 3a3c5b1f7b65f4d86068deda76be1b7141170b8c
Author: Xianwei Zhao <xianwei.zhao at amlogic.com>
dt-bindings: thermal: amlogic: Add A9 thermal bindings
This commit documents the thermal controller compatibles for the Amlogic
A9 SoC. It describes the core and pclk clocks, adds a hardware reset
temperature property, and updates schema constraints.
> diff --git a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
> index 8cfa44dcda58c..5f5dc6f12851d 100644
> --- a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
[ ... ]
> @@ -73,6 +84,22 @@ allOf:
> required:
> - amlogic,secure-monitor
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - amlogic,a9-thermal
> + then:
> + required:
> + - clock-names
> + else:
> + properties:
> + clocks:
> + maxItems: 1
> + clocks-names: false
[Severity: Low]
Does this code intend to restrict the clock-names property here? It appears
there is a typo in the property name (clocks-names instead of clock-names).
Could this typo allow non-A9 variants to define the clock-names property
without failing schema validation?
> + amlogic,hw-reset-temp: false
> +
> unevaluatedProperties: false
>
> examples:
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260730-a9-thermal-v1-0-d786d37cba58@amlogic.com?part=1
More information about the linux-amlogic
mailing list