[PATCH v4 08/15] media: meson-ir-tx: Ensure rc_free_device() is called on unbind
Neil Armstrong
neil.armstrong at linaro.org
Tue Jul 28 01:30:46 PDT 2026
On 7/27/26 15:18, Sean Young wrote:
> Make rc_dev devm managed.
>
> Fixes: dccc0c3ddf8f ("media: rc: fix race between unregister and urb/irq callbacks")
> Signed-off-by: Sean Young <sean at mess.org>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
> Cc: stable at vger.kernel.org
> ---
> drivers/media/rc/meson-ir-tx.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/rc/meson-ir-tx.c b/drivers/media/rc/meson-ir-tx.c
> index e7bb107e6a84..abb107d19e8c 100644
> --- a/drivers/media/rc/meson-ir-tx.c
> +++ b/drivers/media/rc/meson-ir-tx.c
> @@ -345,7 +345,7 @@ static int meson_irtx_probe(struct platform_device *pdev)
> if (ret)
> return dev_err_probe(dev, ret, "irq request failed\n");
>
> - rc = rc_allocate_device(RC_DRIVER_IR_RAW_TX);
> + rc = devm_rc_allocate_device(dev, RC_DRIVER_IR_RAW_TX);
> if (!rc)
> return -ENOMEM;
>
> @@ -358,10 +358,8 @@ static int meson_irtx_probe(struct platform_device *pdev)
> rc->s_tx_duty_cycle = meson_irtx_set_duty_cycle;
>
> ret = devm_rc_register_device(dev, rc);
> - if (ret < 0) {
> - rc_free_device(rc);
> + if (ret < 0)
> return dev_err_probe(dev, ret, "rc_dev registration failed\n");
> - }
>
> return 0;
> }
Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>
Thanks,
Neil
More information about the linux-amlogic
mailing list