[PATCH 3/6] drm/imx/dw-hdmi: convert to of_drm_find_and_get_bridge()
Luca Ceresoli
luca.ceresoli at bootlin.com
Wed Jan 7 09:03:05 PST 2026
Hello Philipp,
On Wed Jan 7, 2026 at 5:34 PM CET, Philipp Zabel wrote:
> On Mi, 2026-01-07 at 17:22 +0100, Luca Ceresoli wrote:
>> of_drm_find_bridge() is deprecated. Move to its replacement
>> of_drm_find_and_get_bridge() which gets a bridge reference, and ensure it
>> is put when done.
>>
>> Signed-off-by: Luca Ceresoli <luca.ceresoli at bootlin.com>
>> ---
>> drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c b/drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c
>> index 07e5f96202d4..95f629d97bce 100644
>> --- a/drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c
>> +++ b/drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c
>> @@ -241,7 +241,7 @@ static int dw_hdmi_imx_probe(struct platform_device *pdev)
>> if (IS_ERR(hdmi->hdmi))
>> return PTR_ERR(hdmi->hdmi);
>>
>> - hdmi->bridge = of_drm_find_bridge(np);
>> + hdmi->bridge = of_drm_find_and_get_bridge(np);
>> if (!hdmi->bridge) {
>> dev_err(hdmi->dev, "Unable to find bridge\n");
>> dw_hdmi_remove(hdmi->hdmi);
>
> The component_add() error path below this is missing a
> drm_bridge_put().
Right! Thanks for reviewing, fix queued for v2.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
More information about the linux-amlogic
mailing list