[PATCH v5 4/8] net: stmmac: qcom-ethqos: wrap emac driver data in additional structure
Konrad Dybcio
konrad.dybcio at oss.qualcomm.com
Fri Nov 7 02:54:33 PST 2025
On 11/7/25 11:29 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski at linaro.org>
>
> As the first step in enabling power domain support in the driver, we'll
> split the device match data and runtime data structures into their
> general and power-management-specific parts. To allow that: first wrap
> the emac driver data in another layer which will later be expanded.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski at linaro.org>
> ---
[...]
> static int qcom_ethqos_probe(struct platform_device *pdev)
> {
> - const struct ethqos_emac_driver_data *data;
> + const struct ethqos_emac_driver_data *drv_data;
> + const struct ethqos_emac_match_data *data;> struct plat_stmmacenet_data *plat_dat;
> struct stmmac_resources stmmac_res;
> struct device *dev = &pdev->dev;
> @@ -801,13 +822,15 @@ static int qcom_ethqos_probe(struct platform_device *pdev)
> ethqos->mac_base = stmmac_res.addr;
>
> data = device_get_match_data(dev);
This change could be made much smaller if you kept a drv_data
pointer named 'data' and called the new one match_data
but I don't really care either way
Reviewed-by: Konrad Dybcio <konrad.dybcio at oss.qualcomm.com>
Konrad
More information about the linux-amlogic
mailing list