No subject
David Lechner
dlechner at baylibre.com
Mon Jul 21 07:09:22 PDT 2025
On 7/21/25 5:15 AM, Sanjay Suthar wrote:
> On Mon, Jul 21, 2025 at 12:22 PM Krzysztof Kozlowski <krzk at kernel.org <mailto:krzk at kernel.org>> wrote:
>>
>> On 20/07/2025 21:30, David Lechner wrote:
>> >> - Ricardo Ribalda Delgado <ricardo at ribalda.com <mailto:ricardo at ribalda.com>>
>> >> diff --git a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
>> >> index 0cd78d71768c..5c91716d1f21 100644
>> >> --- a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
>> >> +++ b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
>> >> @@ -149,7 +149,7 @@ properties:
>> >> - description:
>> >> The first register range should be the one of the DWMAC controller
>> >> - description:
>> >> - The second range is is for the Amlogic specific configuration
>> >> + The second range is for the Amlogic specific configuration
>> >> (for example the PRG_ETHERNET register range on Meson8b and newer)
>> >>
>> >> interrupts:
>> >
>> > I would be tempted to split this into two patches. It's a bit odd to have
>>
>>
>> No, it's a churn to split this into more than one patch.
>>
>
> Thanks for the reply. Since there are suggestions on patch split as it is touching different subsystems, still not clear if I should split the patch or single patch is fine. I would appreciate if you can guide on the next steps to be taken
>
> Best Regards,
> Sanjay Suthar
Krzysztof is one of the devicetree maintainers and I am not, so you
should do what Krzysztof says - leave it as one patch. :-)
More information about the linux-amlogic
mailing list