[PATCH] rtc: amlogic-a4: Optimize global variables

Markus Elfring Markus.Elfring at web.de
Thu Jul 17 08:42:12 PDT 2025


> Use local variables struct regmap_config instread of global

            variable?                      instead?


> variables. The goal of saving memory has been achieve.

                                                achieved?

You may occasionally put more than 59 characters into text lines
of such a change description.


…
> ---
> Use local variables struct regmap_config instread of global
> variables. 
> ---
>  drivers/rtc/rtc-amlogic-a4.c | 14 +++++++-------
…

Please avoid duplicate information here.


Can a summary phrase like “Convert a global variable into a local one
of aml_rtc_probe()” be more appropriate?

Regards,
Markus



More information about the linux-amlogic mailing list