[PATCH v5 3/6] dt-bindings: Asoc: axg-audio: Add s4 audio tocodec

Krzysztof Kozlowski krzk at kernel.org
Mon Jul 14 00:22:58 PDT 2025


On 14/07/2025 08:10, Krzysztof Kozlowski wrote:
> On 10/07/2025 05:35, jiebing chen via B4 Relay wrote:
>> From: jiebing chen <jiebing.chen at amlogic.com>
>>
>> Add S4 SoC tocodec compatibility support.
>>
>> Acked-by: Rob Herring (Arm) <robh at kernel.org>
>> Signed-off-by: Jiebing Chen <jiebing.chen at amlogic.com>
>> ---
> 
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
> 
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
> 
> Thank you.
> </form letter>
> 
You responded in private, but that's not how we discuss here. Please
keep all discussions public.

Above form letter means you received feedback at v1 or v2 and you did
not implement it. You did not respond to it, either.

Please go back to v1 or v2 and implement entire feedback.

Best regards,
Krzysztof



More information about the linux-amlogic mailing list