[PATCH 19/65] media: camss: Replace .open() file operation with v4l2_fh_open()

Vladimir Zapolskiy vladimir.zapolskiy at linaro.org
Sun Aug 24 12:04:45 PDT 2025


Hi Jacopo, Laurent,

thank you for the nice clean-up.

On 8/2/25 12:22, Jacopo Mondi wrote:
> From: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
> The custom video_open() function in the camss driver open-codes the
> v4l2_fh_open() helper, with an additional mutex that protects the whole
> function. Given that the function does not modify any data guarded by
> the lock, there's no need for using the mutex and the function can be
> replaced by v4l2_fh_open().
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>

Tested-by: Vladimir Zapolskiy <vladimir.zapolskiy at linaro.org>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy at linaro.org>

-- 
Best wishes,
Vladimir



More information about the linux-amlogic mailing list