[PATCH 0/7] iio: Remove dev_err_probe() if error is -ENOMEM

Crt Mori cmo at melexis.com
Thu Aug 21 04:50:00 PDT 2025


Sorry duplicate - as I commented on driver.

On Thu, 21 Aug 2025 at 10:13, Andy Shevchenko <andy.shevchenko at gmail.com> wrote:
>
> On Thu, Aug 21, 2025 at 11:07 AM Xichao Zhao <zhao.xichao at vivo.com> wrote:
> >
> > The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
>
> when the error
>
> > Therefore, remove the useless call to dev_err_probe(), and just
> > return the value instead.
>
> In favour of this series,
> Reviewed-by: Andy Shevchenko <andy at kernel.org>
> (yes, I indeed looked at all patches in this one :-)
>
I am not sure I agree with this. It provides an error message with
reason and I understand we want as few as possible, but this would be
a valid remark inside the logs, but without it we only get error value
to figure out where it comes from?

> --
> With Best Regards,
> Andy Shevchenko



More information about the linux-amlogic mailing list