[PATCH 63/65] media: ipu6: isys: Don't set V4L2_FL_USES_V4L2_FH manually

[Cao, Bingbu]

Jacopo,

>-----Original Message-----
>From: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
>Sent: Saturday, August 2, 2025 5:23 PM
>To: Mauro Carvalho Chehab <mchehab at kernel.org>; Devarsh Thakkar
><devarsht at ti.com>; Benoit Parrot <bparrot at ti.com>; Hans Verkuil
><hverkuil at kernel.org>; Mike Isely <isely at pobox.com>; Laurent Pinchart
><laurent.pinchart at ideasonboard.com>; Hans de Goede <hansg at kernel.org>;
>Parthiban Veerasooran <parthiban.veerasooran at microchip.com>; Christian
>Gromm <christian.gromm at microchip.com>; Greg Kroah-Hartman
><gregkh at linuxfoundation.org>; Alex Shi <alexs at kernel.org>; Yanteng Si
><si.yanteng at linux.dev>; Dongliang Mu <dzm91 at hust.edu.cn>; Jonathan
>Corbet <corbet at lwn.net>; Tomasz Figa <tfiga at chromium.org>; Marek
>Szyprowski <m.szyprowski at samsung.com>; Andy Walls
><awalls at md.metrocast.net>; Michael Tretter <m.tretter at pengutronix.de>;
>Pengutronix Kernel Team <kernel at pengutronix.de>; Bin Liu
><bin.liu at mediatek.com>; Matthias Brugger <matthias.bgg at gmail.com>;
>AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>;
>Dmitry Osipenko <digetx at gmail.com>; Thierry Reding
><thierry.reding at gmail.com>; Jonathan Hunter <jonathanh at nvidia.com>;
>Mirela Rabulea <mirela.rabulea at nxp.com>; Shawn Guo
><shawnguo at kernel.org>; Sascha Hauer <s.hauer at pengutronix.de>; Fabio
>Estevam <festevam at gmail.com>; Kieran Bingham
><kieran.bingham+renesas at ideasonboard.com>; Michal Simek
><michal.simek at amd.com>; Ming Qian <ming.qian at nxp.com>; Zhou Peng
><eagle.zhou at nxp.com>; Xavier Roumegue <xavier.roumegue at oss.nxp.com>;
>Philipp Zabel <p.zabel at pengutronix.de>; Vikash Garodia
><quic_vgarodia at quicinc.com>; Dikshita Agarwal
><quic_dikshita at quicinc.com>; Abhinav Kumar <abhinav.kumar at linux.dev>;
>Bryan O'Donoghue <bryan.odonoghue at linaro.org>; Sylwester Nawrocki
><sylvester.nawrocki at gmail.com>; Jernej Skrabec
><jernej.skrabec at gmail.com>; Chen-Yu Tsai <wens at csie.org>; Samuel
>Holland <samuel at sholland.org>; Daniel Almeida
><daniel.almeida at collabora.com>; Neil Armstrong
><neil.armstrong at linaro.org>; Kevin Hilman <khilman at baylibre.com>;
>Jerome Brunet <jbrunet at baylibre.com>; Martin Blumenstingl
><martin.blumenstingl at googlemail.com>; Nas Chung
><nas.chung at chipsnmedia.com>; Jackson Lee <jackson.lee at chipsnmedia.com>;
>Minghsiu Tsai <minghsiu.tsai at mediatek.com>; Houlong Wei
><houlong.wei at mediatek.com>; Andrew-CT Chen <andrew-
>ct.chen at mediatek.com>; Tiffany Lin <tiffany.lin at mediatek.com>; Yunfei
>Dong <yunfei.dong at mediatek.com>; Geert Uytterhoeven
><geert+renesas at glider.be>; Magnus Damm <magnus.damm at gmail.com>; Mikhail
>Ulyanov <mikhail.ulyanov at cogentembedded.com>; Jacob Chen <jacob-
>chen at iotwrt.com>; Ezequiel Garcia <ezequiel at vanguardiasur.com.ar>;
>Heiko Stuebner <heiko at sntech.de>; Detlev Casanova
><detlev.casanova at collabora.com>; Krzysztof Kozlowski <krzk at kernel.org>;
>Alim Akhtar <alim.akhtar at samsung.com>; Sylwester Nawrocki
><s.nawrocki at samsung.com>; Łukasz Stelmach <l.stelmach at samsung.com>;
>Andrzej Pietrasiewicz <andrzejtp2010 at gmail.com>; Jacek Anaszewski
><jacek.anaszewski at gmail.com>; Hajda, Andrzej <andrzej.hajda at intel.com>;
>Fabien Dessenne <fabien.dessenne at foss.st.com>; Hugues Fruchet
><hugues.fruchet at foss.st.com>; Jean-Christophe Trotin <jean-
>christophe.trotin at foss.st.com>; Maxime Coquelin
><mcoquelin.stm32 at gmail.com>; Alexandre Torgue
><alexandre.torgue at foss.st.com>; Nicolas Dufresne
><nicolas.dufresne at collabora.com>; Benjamin Gaignard
><benjamin.gaignard at collabora.com>; Steve Longerbeam
><slongerbeam at gmail.com>; Maxime Ripard <mripard at kernel.org>; Paul
>Kocialkowski <paulk at sys-base.io>; Niklas Söderlund
><niklas.soderlund at ragnatech.se>; Robert Foss <rfoss at kernel.org>; Todor
>Tomov <todor.too at gmail.com>; Vladimir Zapolskiy
><vladimir.zapolskiy at linaro.org>; Corentin Labbe <clabbe at baylibre.com>;
>Sakari Ailus <sakari.ailus at linux.intel.com>; Cao, Bingbu
><bingbu.cao at intel.com>; Qiu, Tian Shu <tian.shu.qiu at intel.com>;
>Stanislaw Gruszka <stanislaw.gruszka at linux.intel.com>
>Cc: linux-media at vger.kernel.org; linux-kernel at vger.kernel.org; linux-
>staging at lists.linux.dev; linux-doc at vger.kernel.org; linux-arm-
>kernel at lists.infradead.org; linux-mediatek at lists.infradead.org; linux-
>tegra at vger.kernel.org; imx at lists.linux.dev; linux-renesas-
>soc at vger.kernel.org; linux-arm-msm at vger.kernel.org; linux-samsung-
>soc at vger.kernel.org; linux-sunxi at lists.linux.dev; linux-
>usb at vger.kernel.org; linux-amlogic at lists.infradead.org; linux-
>rockchip at lists.infradead.org; linux-stm32 at st-md-mailman.stormreply.com;
>mjpeg-users at lists.sourceforge.net; Jacopo Mondi
><jacopo.mondi at ideasonboard.com>
>Subject: [PATCH 63/65] media: ipu6: isys: Don't set
>V4L2_FL_USES_V4L2_FH manually
>
>From: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>
>The V4L2_FL_USES_V4L2_FH flag is set by v4l2_fh_init(). It is not meant
>to be set manually by drivers. Drop it from the ipu6-isys driver.
>
>Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>Signed-off-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
>---
> drivers/media/pci/intel/ipu6/ipu6-isys-video.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
>b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
>index
>24a2ef93474cc400f64eb1d50bc760ee66124d1b..f3f3bc0615e5dc698be5c479dfed8
>ef2eb49cbfb 100644
>--- a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
>+++ b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
>@@ -1306,7 +1306,6 @@ int ipu6_isys_video_init(struct ipu6_isys_video
>*av)
> 	__ipu6_isys_vidioc_try_fmt_meta_cap(av, &format_meta);
> 	av->meta_fmt = format_meta.fmt.meta;
>
>-	set_bit(V4L2_FL_USES_V4L2_FH, &av->vdev.flags);
> 	video_set_drvdata(&av->vdev, av);
>
> 	ret = video_register_device(&av->vdev, VFL_TYPE_VIDEO, -1);
>
>--
>2.49.0

Thanks for the patch.

Reviewed-by: Bingbu Cao <bingbu.cao at intel.com>