[EXT] [PATCH 13/65] media: amphion: Make some vpu_v4l2 functions static
Ming Qian
ming.qian at nxp.com
Mon Aug 4 18:34:44 PDT 2025
>-----Original Message-----
>From: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
>Sent: Saturday, August 2, 2025 5:23 PM
>To: Mauro Carvalho Chehab <mchehab at kernel.org>; Devarsh Thakkar
><devarsht at ti.com>; Benoit Parrot <bparrot at ti.com>; Hans Verkuil
><hverkuil at kernel.org>; Mike Isely <isely at pobox.com>; Laurent Pinchart
><laurent.pinchart at ideasonboard.com>; Hans de Goede <hansg at kernel.org>;
>Parthiban Veerasooran <parthiban.veerasooran at microchip.com>; Christian
>Gromm <christian.gromm at microchip.com>; Greg Kroah-Hartman
><gregkh at linuxfoundation.org>; Alex Shi <alexs at kernel.org>; Yanteng Si
><si.yanteng at linux.dev>; Dongliang Mu <dzm91 at hust.edu.cn>; Jonathan
>Corbet <corbet at lwn.net>; Tomasz Figa <tfiga at chromium.org>; Marek
>Szyprowski <m.szyprowski at samsung.com>; Andy Walls
><awalls at md.metrocast.net>; Michael Tretter <m.tretter at pengutronix.de>;
>Pengutronix Kernel Team <kernel at pengutronix.de>; Bin Liu
><bin.liu at mediatek.com>; Matthias Brugger <matthias.bgg at gmail.com>;
>AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>;
>Dmitry Osipenko <digetx at gmail.com>; Thierry Reding
><thierry.reding at gmail.com>; Jonathan Hunter <jonathanh at nvidia.com>;
>Mirela Rabulea <mirela.rabulea at nxp.com>; Shawn Guo
><shawnguo at kernel.org>; Sascha Hauer <s.hauer at pengutronix.de>; Fabio
>Estevam <festevam at gmail.com>; Kieran Bingham
><kieran.bingham+renesas at ideasonboard.com>; Michal Simek
><michal.simek at amd.com>; Ming Qian <ming.qian at nxp.com>; Eagle Zhou
><eagle.zhou at nxp.com>; Xavier Roumegue (OSS)
><xavier.roumegue at oss.nxp.com>; Philipp Zabel <p.zabel at pengutronix.de>;
>Vikash Garodia <quic_vgarodia at quicinc.com>; Dikshita Agarwal
><quic_dikshita at quicinc.com>; Abhinav Kumar <abhinav.kumar at linux.dev>;
>Bryan O'Donoghue <bryan.odonoghue at linaro.org>; Sylwester Nawrocki
><sylvester.nawrocki at gmail.com>; Jernej Skrabec <jernej.skrabec at gmail.com>;
>Chen-Yu Tsai <wens at csie.org>; Samuel Holland <samuel at sholland.org>;
>Daniel Almeida <daniel.almeida at collabora.com>; Neil Armstrong
><neil.armstrong at linaro.org>; Kevin Hilman <khilman at baylibre.com>; Jerome
>Brunet <jbrunet at baylibre.com>; Martin Blumenstingl
><martin.blumenstingl at googlemail.com>; Nas Chung
><nas.chung at chipsnmedia.com>; Jackson Lee
><jackson.lee at chipsnmedia.com>; Minghsiu Tsai
><minghsiu.tsai at mediatek.com>; Houlong Wei <houlong.wei at mediatek.com>;
>Andrew-CT Chen <andrew-ct.chen at mediatek.com>; Tiffany Lin
><tiffany.lin at mediatek.com>; Yunfei Dong <yunfei.dong at mediatek.com>;
>Geert Uytterhoeven <geert+renesas at glider.be>; Magnus Damm
><magnus.damm at gmail.com>; Mikhail Ulyanov
><mikhail.ulyanov at cogentembedded.com>; Jacob Chen <jacob-
>chen at iotwrt.com>; Ezequiel Garcia <ezequiel at vanguardiasur.com.ar>; Heiko
>Stuebner <heiko at sntech.de>; Detlev Casanova
><detlev.casanova at collabora.com>; Krzysztof Kozlowski <krzk at kernel.org>;
>Alim Akhtar <alim.akhtar at samsung.com>; Sylwester Nawrocki
><s.nawrocki at samsung.com>; Łukasz Stelmach <l.stelmach at samsung.com>;
>Andrzej Pietrasiewicz <andrzejtp2010 at gmail.com>; Jacek Anaszewski
><jacek.anaszewski at gmail.com>; Andrzej Hajda <andrzej.hajda at intel.com>;
>Fabien Dessenne <fabien.dessenne at foss.st.com>; Hugues Fruchet
><hugues.fruchet at foss.st.com>; Jean-Christophe Trotin <jean-
>christophe.trotin at foss.st.com>; Maxime Coquelin
><mcoquelin.stm32 at gmail.com>; Alexandre Torgue
><alexandre.torgue at foss.st.com>; Nicolas Dufresne
><nicolas.dufresne at collabora.com>; Benjamin Gaignard
><benjamin.gaignard at collabora.com>; Steve Longerbeam
><slongerbeam at gmail.com>; Maxime Ripard <mripard at kernel.org>; Paul
>Kocialkowski <paulk at sys-base.io>; Niklas Söderlund
><niklas.soderlund at ragnatech.se>; Robert Foss <rfoss at kernel.org>; Todor
>Tomov <todor.too at gmail.com>; Vladimir Zapolskiy
><vladimir.zapolskiy at linaro.org>; Corentin Labbe <clabbe at baylibre.com>;
>Sakari Ailus <sakari.ailus at linux.intel.com>; Bingbu Cao
><bingbu.cao at intel.com>; Tianshu Qiu <tian.shu.qiu at intel.com>; Stanislaw
>Gruszka <stanislaw.gruszka at linux.intel.com>
>Cc: linux-media at vger.kernel.org; linux-kernel at vger.kernel.org; linux-
>staging at lists.linux.dev; linux-doc at vger.kernel.org; linux-arm-
>kernel at lists.infradead.org; linux-mediatek at lists.infradead.org; linux-
>tegra at vger.kernel.org; imx at lists.linux.dev; linux-renesas-soc at vger.kernel.org;
>linux-arm-msm at vger.kernel.org; linux-samsung-soc at vger.kernel.org; linux-
>sunxi at lists.linux.dev; linux-usb at vger.kernel.org; linux-
>amlogic at lists.infradead.org; linux-rockchip at lists.infradead.org; linux-
>stm32 at st-md-mailman.stormreply.com; mjpeg-users at lists.sourceforge.net;
>Jacopo Mondi <jacopo.mondi at ideasonboard.com>
>Subject: [EXT] [PATCH 13/65] media: amphion: Make some vpu_v4l2 functions
>static
>
>Caution: This is an external email. Please take care when clicking links or
>opening attachments. When in doubt, report the message using the 'Report
>this email' button
>
>
>From: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>
>Some functions defined in vpu_v4l2.c are never used outside of that
>compilation unit. Make them static.
>
>Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>Signed-off-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
Reviewed-by: Ming Qian <ming.qian at oss.nxp.com>
>---
> drivers/media/platform/amphion/vpu_v4l2.c | 12 +++++++++---
>drivers/media/platform/amphion/vpu_v4l2.h | 8 --------
> 2 files changed, 9 insertions(+), 11 deletions(-)
>
>diff --git a/drivers/media/platform/amphion/vpu_v4l2.c
>b/drivers/media/platform/amphion/vpu_v4l2.c
>index
>74668fa362e24fd34829b500e99c8455a9413fc1..306d94e0f8e79faaacfa35b28e
>5786860f7bd1ca 100644
>--- a/drivers/media/platform/amphion/vpu_v4l2.c
>+++ b/drivers/media/platform/amphion/vpu_v4l2.c
>@@ -24,6 +24,11 @@
> #include "vpu_msgs.h"
> #include "vpu_helpers.h"
>
>+static char *vpu_type_name(u32 type)
>+{
>+ return V4L2_TYPE_IS_OUTPUT(type) ? "output" : "capture"; }
>+
> void vpu_inst_lock(struct vpu_inst *inst) {
> mutex_lock(&inst->lock);
>@@ -42,7 +47,7 @@ dma_addr_t vpu_get_vb_phy_addr(struct vb2_buffer
>*vb, u32 plane_no)
> vb->planes[plane_no].data_offset; }
>
>-unsigned int vpu_get_vb_length(struct vb2_buffer *vb, u32 plane_no)
>+static unsigned int vpu_get_vb_length(struct vb2_buffer *vb, u32
>+plane_no)
> {
> if (plane_no >= vb->num_planes)
> return 0;
>@@ -81,7 +86,7 @@ void vpu_v4l2_set_error(struct vpu_inst *inst)
> vpu_inst_unlock(inst);
> }
>
>-int vpu_notify_eos(struct vpu_inst *inst)
>+static int vpu_notify_eos(struct vpu_inst *inst)
> {
> static const struct v4l2_event ev = {
> .id = 0,
>@@ -573,7 +578,8 @@ static void vpu_vb2_buf_finish(struct vb2_buffer *vb)
> call_void_vop(inst, on_queue_empty, q->type); }
>
>-void vpu_vb2_buffers_return(struct vpu_inst *inst, unsigned int type, enum
>vb2_buffer_state state)
>+static void vpu_vb2_buffers_return(struct vpu_inst *inst, unsigned int type,
>+ enum vb2_buffer_state state)
> {
> struct vb2_v4l2_buffer *buf;
>
>diff --git a/drivers/media/platform/amphion/vpu_v4l2.h
>b/drivers/media/platform/amphion/vpu_v4l2.h
>index
>56f2939fa84d07b7ea07e889ab5ad3bb7ca9ab5c..4a87b06ae520306ede356b6f
>3309d8b4a67c204a 100644
>--- a/drivers/media/platform/amphion/vpu_v4l2.h
>+++ b/drivers/media/platform/amphion/vpu_v4l2.h
>@@ -26,15 +26,12 @@ void vpu_skip_frame(struct vpu_inst *inst, int count);
>struct vb2_v4l2_buffer *vpu_find_buf_by_sequence(struct vpu_inst *inst, u32
>type, u32 sequence); struct vb2_v4l2_buffer *vpu_find_buf_by_idx(struct
>vpu_inst *inst, u32 type, u32 idx); void vpu_v4l2_set_error(struct vpu_inst
>*inst); -int vpu_notify_eos(struct vpu_inst *inst); int
>vpu_notify_source_change(struct vpu_inst *inst); int
>vpu_set_last_buffer_dequeued(struct vpu_inst *inst, bool eos); -void
>vpu_vb2_buffers_return(struct vpu_inst *inst, unsigned int type, enum
>vb2_buffer_state state); int vpu_get_num_buffers(struct vpu_inst *inst, u32
>type); bool vpu_is_source_empty(struct vpu_inst *inst);
>
> dma_addr_t vpu_get_vb_phy_addr(struct vb2_buffer *vb, u32 plane_no); -
>unsigned int vpu_get_vb_length(struct vb2_buffer *vb, u32 plane_no); static
>inline struct vpu_format *vpu_get_format(struct vpu_inst *inst, u32 type) {
> if (V4L2_TYPE_IS_OUTPUT(type))
>@@ -43,11 +40,6 @@ static inline struct vpu_format *vpu_get_format(struct
>vpu_inst *inst, u32 type)
> return &inst->cap_format; }
>
>-static inline char *vpu_type_name(u32 type) -{
>- return V4L2_TYPE_IS_OUTPUT(type) ? "output" : "capture";
>-}
>-
> static inline int vpu_vb_is_codecconfig(struct vb2_v4l2_buffer *vbuf) { #ifdef
>V4L2_BUF_FLAG_CODECCONFIG
>
>--
>2.49.0
More information about the linux-amlogic
mailing list