[PATCH] arm64: dts: amlogic: gxl: set i2c bias to pull-up

[Da Xue]

On Sun, Apr 27, 2025 at 5:11 PM Martin Blumenstingl
<martin.blumenstingl at googlemail.com> wrote:
>
> On Fri, Apr 25, 2025 at 10:31 PM Da Xue <da at libre.computer> wrote:
> >
> > GXL I2C pins need internal pull-up enabled to operate if there
> > is no external resistor. The pull-up is 60kohms per the datasheet.
> >
> > We should set the bias when i2c pinmux is enabled.
> >
> > Signed-off-by: Da Xue <da at libre.computer>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
>
> +Xianwei Zhao (who has recently upstreamed Amlogic A4 pinctrl support).
> I suspect we need a similar change for all other (Meson8, Meson8b,
> GXBB, G12A, ...) SoCs as well.
> Can you confirm this? And if not, why does only GXL need this special treatment?

We've only tested this extensively on GXL (S805X, S905D, S905X). I
think we should enable it for all SoCs if this patch doesn't cause any
issues. I don't see most Amlogic boards implement pull-ups but I
haven't tested that as extensively as I've done for these.

>
>
> Best regards,
> Martin
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic