[PATCH 5/5] clk: sunxi: Do not enable by default during compile testing

[Chen-Yu Tsai]

On Fri, Apr 4, 2025 at 7:57 PM Krzysztof Kozlowski
<krzysztof.kozlowski at linaro.org> wrote:
>
> Enabling the compile test should not cause automatic enabling of all
> drivers.  Restrict the default to ARCH also for individual drivers, even
> though their choice is not visible without selecting parent Kconfig
> symbol, because otherwise selecting parent would select the child during
> compile testing.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> ---
>  drivers/clk/sunxi/Kconfig | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/clk/sunxi/Kconfig b/drivers/clk/sunxi/Kconfig
> index 1c4e543366ddb76c1669b577c1ac337dc1be616f..5e2f92bfe4120981ab68b175dce798ac8b3268b0 100644
> --- a/drivers/clk/sunxi/Kconfig
> +++ b/drivers/clk/sunxi/Kconfig
> @@ -2,13 +2,13 @@
>  menuconfig CLK_SUNXI
>         bool "Legacy clock support for Allwinner SoCs"
>         depends on (ARM && ARCH_SUNXI) || COMPILE_TEST
> -       default y
> +       default (ARM && ARCH_SUNXI)

Just wondering, shouldn't this change alone be enough? The remaining
Kconfig options are gated by this one.

ChenYU

>  if CLK_SUNXI
>
>  config CLK_SUNXI_CLOCKS
>         bool "Legacy clock drivers"
> -       default y
> +       default ARCH_SUNXI
>         help
>           Legacy clock drivers being used on older (A10, A13, A20,
>           A23, A31, A80) SoCs. These drivers are kept around for
> @@ -19,14 +19,14 @@ config CLK_SUNXI_CLOCKS
>
>  config CLK_SUNXI_PRCM_SUN6I
>         bool "Legacy A31 PRCM driver"
> -       default y
> +       default ARCH_SUNXI
>         help
>           Legacy clock driver for the A31 PRCM clocks. Those are
>           usually needed for the PMIC communication, mostly.
>
>  config CLK_SUNXI_PRCM_SUN8I
>         bool "Legacy sun8i PRCM driver"
> -       default y
> +       default ARCH_SUNXI
>         help
>           Legacy clock driver for the sun8i family PRCM clocks.
>           Those are usually needed for the PMIC communication,
> @@ -34,7 +34,7 @@ config CLK_SUNXI_PRCM_SUN8I
>
>  config CLK_SUNXI_PRCM_SUN9I
>         bool "Legacy A80 PRCM driver"
> -       default y
> +       default ARCH_SUNXI
>         help
>           Legacy clock driver for the A80 PRCM clocks. Those are
>           usually needed for the PMIC communication, mostly.
>
> --
> 2.45.2
>
>