[PATCH 18/19] dt-bindings: arm/cpus: Add power-domains constraints
Rob Herring
robh at kernel.org
Mon Apr 7 09:50:37 PDT 2025
On Mon, Apr 7, 2025 at 11:23 AM Ulf Hansson <ulf.hansson at linaro.org> wrote:
>
> On Fri, 4 Apr 2025 at 15:09, Rob Herring <robh at kernel.org> wrote:
> >
> > On Fri, Apr 4, 2025 at 5:37 AM Ulf Hansson <ulf.hansson at linaro.org> wrote:
> > >
> > > On Fri, 4 Apr 2025 at 05:06, Rob Herring (Arm) <robh at kernel.org> wrote:
> > > >
> > > > The "power-domains" and "power-domains-names" properties are missing any
> > > > constraints. Add the constraints and drop the generic descriptions.
> > > >
> > > > Signed-off-by: Rob Herring (Arm) <robh at kernel.org>
> > > > ---
> > > > Documentation/devicetree/bindings/arm/cpus.yaml | 8 ++------
> > > > 1 file changed, 2 insertions(+), 6 deletions(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
> > > > index 6f74ebfd38df..5bd5822db8af 100644
> > > > --- a/Documentation/devicetree/bindings/arm/cpus.yaml
> > > > +++ b/Documentation/devicetree/bindings/arm/cpus.yaml
> > > > @@ -313,19 +313,15 @@ properties:
> > > > maxItems: 1
> > > >
> > > > power-domains:
> > > > - description:
> > > > - List of phandles and PM domain specifiers, as defined by bindings of the
> > > > - PM domain provider (see also ../power_domain.txt).
> > > > + maxItems: 1
> > >
> > > There are more than one in some cases. The most is probably three, I think.
> >
> > Unless I missed it, testing says otherwise. What would the names be if
> > more than 1 entry?
>
> "psci", "perf", "cpr", etc
>
> The "psci" is always for CPU power management, the other is for CPU
> performance scaling (which may be more than one power-domain in some
> cases).
>
> I would suggest changing this to "maxItems: 3". That should be
> sufficient I think.
Again, my testing says 1 is enough. So where is a .dts file with 3 or 2?
Rob
More information about the linux-amlogic
mailing list