[PATCH v2 1/4] pwm: meson: Simplify get_state() callback
Uwe Kleine-König
u.kleine-koenig at baylibre.com
Mon Nov 4 01:08:02 PST 2024
On Wed, Oct 16, 2024 at 06:25:50PM +0300, George Stark wrote:
> In .get_state() callback meson_pwm_channel struct are used to store
> lo and hi reg values but they are never reused after that so
> for clearness use local variable instead.
>
> Signed-off-by: George Stark <gnstark at salutedevices.com>
> ---
> drivers/pwm/pwm-meson.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
> index 98e6c1533312..2ef632caebcc 100644
> --- a/drivers/pwm/pwm-meson.c
> +++ b/drivers/pwm/pwm-meson.c
> @@ -310,6 +310,7 @@ static int meson_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
> struct meson_pwm *meson = to_meson_pwm(chip);
> struct meson_pwm_channel_data *channel_data;
> struct meson_pwm_channel *channel;
> + unsigned int hi, lo;
> u32 value;
>
> channel = &meson->channels[pwm->hwpwm];
> @@ -319,11 +320,11 @@ static int meson_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
> state->enabled = value & channel_data->pwm_en_mask;
>
> value = readl(meson->base + channel_data->reg_offset);
> - channel->lo = FIELD_GET(PWM_LOW_MASK, value);
> - channel->hi = FIELD_GET(PWM_HIGH_MASK, value);
> + lo = FIELD_GET(PWM_LOW_MASK, value);
> + hi = FIELD_GET(PWM_HIGH_MASK, value);
>
> - state->period = meson_pwm_cnt_to_ns(chip, pwm, channel->lo + channel->hi);
> - state->duty_cycle = meson_pwm_cnt_to_ns(chip, pwm, channel->hi);
> + state->period = meson_pwm_cnt_to_ns(chip, pwm, lo + hi);
> + state->duty_cycle = meson_pwm_cnt_to_ns(chip, pwm, hi);
>
> state->polarity = PWM_POLARITY_NORMAL;
Fine for me if you drop the local variable channel as found by the build
bot.
Best regards
Uwe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-amlogic/attachments/20241104/c0916477/attachment.sig>
More information about the linux-amlogic
mailing list