[PATCH RFC] ASoC: amlogic: do not use dpcm_playback/capture flags

Jerome Brunet jbrunet at baylibre.com
Wed May 15 06:01:35 PDT 2024


On Tue 14 May 2024 at 23:11, Kuninori Morimoto <kuninori.morimoto.gx at renesas.com> wrote:

> Hi
>
>> > dpcm_playback/capture flags are being deprecated in ASoC.
>> > Use playback/capture_only flags instead
>> > 
>> > Suggested-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
>> > Signed-off-by: Jerome Brunet <jbrunet at baylibre.com>
>> > ---
>> > 
>> > Following Kuninori's series, dpcm_playback/capture will be ignored.
>> > However, properly disabling stream direction is important for Amlogic
>> > audio drivers.
>> > 
>> > I'm not too sure how this should be applied to avoid breaking bisect,
>> > before or after Kuninori's series. Maybe it should be merged into it ?
>> 
>> Probably better to integrate it I think?
>
> ASoC needs dpcm_xxx flag *before* my patch.
> Your patch is replacing it to xxx_only flag, so it should be applied
> *after* my patch. So integrate/merge is good idea, I think.

Ok. Then I guess it is up to you and Mark.
Please let me know if you need me for anything.

Cheers

>
> Thank you for your help !!
>
> Best regards
> ---
> Renesas Electronics
> Ph.D. Kuninori Morimoto


-- 
Jerome



More information about the linux-amlogic mailing list