[PATCH 08/25] ASoC: dt-bindings: meson: g12a-toacodec: add support for A1 SoC family

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Fri Mar 15 02:58:34 PDT 2024


On 15/03/2024 00:21, Jan Dakinevich wrote:
> Add "amlogic,t9015-a1" compatible string and new device tree phandle
> options.

I don't understand the second part. You did not add any options, no
phandles. You added some defines for something, so say what are these
"something".

> 
> Signed-off-by: Jan Dakinevich <jan.dakinevich at salutedevices.com>
> ---
>  .../devicetree/bindings/sound/amlogic,g12a-toacodec.yaml     | 1 +
>  include/dt-bindings/sound/meson-g12a-toacodec.h              | 5 +++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml b/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml
> index 23f82bb89750..c47604aa590f 100644
> --- a/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml
> +++ b/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml
> @@ -26,6 +26,7 @@ properties:
>        - items:
>            - enum:
>                - amlogic,sm1-toacodec
> +              - amlogic,a1-toacodec

Keep alphabetical order. Don't stuff new entries to the end...




Best regards,
Krzysztof




More information about the linux-amlogic mailing list