[PATCH] nvmem: meson-mx-efuse: Remove nvmem_device from efuse struct
Mukesh Ojha
quic_mojha at quicinc.com
Tue Mar 12 09:12:36 PDT 2024
Hi Martin,
On 3/8/2024 2:26 AM, Martin Blumenstingl wrote:
> Hello Mukesh,
>
> On Tue, Mar 5, 2024 at 7:58 AM Mukesh Ojha <quic_mojha at quicinc.com> wrote:
>>
>> nvmem_device is used at one place while registering nvmem
>> device and it is not required to be present in efuse struct
>> for just this purpose.
>>
>> Drop nvmem_device and manage with nvmem device stack variable.
> I'm generally fine with this approach
Thanks.
Sorry for the late reply, was on vacation.
>
> [...]
>> @@ -223,9 +222,9 @@ static int meson_mx_efuse_probe(struct platform_device *pdev)
>> return PTR_ERR(efuse->core_clk);
>> }
>>
>> - efuse->nvmem = devm_nvmem_register(&pdev->dev, &efuse->config);
>> + nvmem = devm_nvmem_register(&pdev->dev, &efuse->config);
> But this doesn't compile for me:
> CC drivers/nvmem/meson-mx-efuse.o
> ../drivers/nvmem/meson-mx-efuse.c: In function 'meson_mx_efuse_probe':
> ../drivers/nvmem/meson-mx-efuse.c:252:9: error: 'nvmem' undeclared
> (first use in this function)
> 252 | nvmem = devm_nvmem_register(&pdev->dev, &efuse->config);
Sent too soon., change was cached never got commited..
v2:
https://lore.kernel.org/lkml/1710259663-14095-1-git-send-email-quic_mojha@quicinc.com/
Thanks,
-Mukesh
>
>
> Best regards,
> Martin
More information about the linux-amlogic
mailing list