[PATCH] arm64: dts: amlogic: replace underscores in node names

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Tue Feb 13 06:56:08 PST 2024


On 13/02/2024 15:42, Marc Gonzalez wrote:
> [ Trimming recipients list because my comment is very tangential, almost irrelevant ]
> 
> On 13/02/2024 15:32, Krzysztof Kozlowski wrote:
> 
>> Underscores should not be used in node names (dtc with W=2 warns about
>> them), so replace them with hyphens.
>>
>> Cc: Marc Gonzalez <mgonzalez at freebox.fr>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>> ---
>>  .../arm64/boot/dts/amlogic/meson-a1-ad402.dts |  2 +-
>>  .../meson-axg-jethome-jethub-j1xx.dtsi        | 14 ++++++-------
> 
> I use stat=120 so that format-patch doesn't truncate the path.
> 
> Without it, it's hard to tell if fixes only target arch/arm64/boot/dts/amlogic
> 
> BTW, I didn't mean to single out arch/arm64/boot/dts/amlogic,
> it's just the tree I'm working on at the moment. The issues
> are wider than that:
> 
> $ git grep -i ' [_a-z0-9-]*_[_a-z0-9-]* {' arch/arm64/boot/dts | wc -l

I know. I fixed few platforms in the past, fixed few more now.

Best regards,
Krzysztof




More information about the linux-amlogic mailing list