[PATCH v2 3/4] arm64: dts: amlogic: add fbx8am board

[Marc Gonzalez]

On 13/02/2024 09:42, Krzysztof Kozlowski wrote:

> On 12/02/2024 18:51, Marc Gonzalez wrote:
>
>> The fbx8am boards are based on the Amlogic Meson G12A S905X2 SoC,
>> and the SEI510 board design.
> 
> ...
> 
>> +	ao_5v: regulator-ao_5v {
> 
> No underscores in node names.
> 
> Didn't you get such comment before?

For the record, this submission is, mostly, a copy of meson-g12a-sei510.dts

Thus, I did not consider diverging from meson-g12a-sei510.dts

$ git grep -i ' [_a-z0-9-]*_[_a-z0-9-]* {' arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts | wc -l
6

$ git grep -i ' [_a-z0-9-]*_[_a-z0-9-]* {' arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am.dts
arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am.dts:      ao_5v: regulator-ao_5v {
arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am.dts:      dc_in: regulator-dc_in {
arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am.dts:      emmc_1v8: regulator-emmc_1v8 {
arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am.dts:      vddao_3v3: regulator-vddao_3v3 {
arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am.dts:      vddao_3v3_t: regultor-vddao_3v3_t {
arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am.dts:      vddio_ao1v8: regulator-vddio_ao1v8 {


IIUC, you're saying it is preferable to fix the node names in new trees,
even if it means diverging? (Using dashes instead of underscores?)


For the record:

$ git grep -i ' [_a-z0-9-]*_[_a-z0-9-]* {' arch/arm64/boot/dts/amlogic | wc -l
397