[PATCH 1/3] dt-bindings: rtc: Add Amlogic A311L2 and A113X2 rtc
Xianwei Zhao
xianwei.zhao at amlogic.com
Sun Aug 25 19:36:42 PDT 2024
Hi Conor,
Thanks for your reply.
On 2024/8/23 23:51, Conor Dooley wrote:
> Subject:
> Re: [PATCH 1/3] dt-bindings: rtc: Add Amlogic A311L2 and A113X2 rtc
> From:
> Conor Dooley <conor at kernel.org>
> Date:
> 2024/8/23 23:51
>
> To:
> xianwei.zhao at amlogic.com
> CC:
> Yiting Deng <yiting.deng at amlogic.com>, Alexandre Belloni
> <alexandre.belloni at bootlin.com>, Rob Herring <robh at kernel.org>,
> Krzysztof Kozlowski <krzk+dt at kernel.org>, Conor Dooley
> <conor+dt at kernel.org>, linux-amlogic at lists.infradead.org,
> linux-rtc at vger.kernel.org, devicetree at vger.kernel.org,
> linux-kernel at vger.kernel.org
>
>
> On Fri, Aug 23, 2024 at 05:19:44PM +0800, Xianwei Zhao via B4 Relay wrote:
>> From: Yiting Deng<yiting.deng at amlogic.com>
>>
>> Add documentation describing the Amlogic A113L2 and A113X2 rtc controller.
>>
>> Signed-off-by: Yiting Deng<yiting.deng at amlogic.com>
>> Signed-off-by: Xianwei Zhao<xianwei.zhao at amlogic.com>
>> ---
>> .../bindings/rtc/amlogic,amlogic-rtc.yaml | 66 ++++++++++++++++++++++
>> 1 file changed, 66 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/rtc/amlogic,amlogic-rtc.yaml b/Documentation/devicetree/bindings/rtc/amlogic,amlogic-rtc.yaml
>> new file mode 100644
>> index 000000000000..fa3d7838022e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/rtc/amlogic,amlogic-rtc.yaml
> Filename matching a compatible please.
>
Will do, modify the name to "amlogic,a4-rtc.yaml".
>> @@ -0,0 +1,66 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +# Copyright (C) 2024 Amlogic, Inc. All rights reserved
>> +%YAML 1.2
>> +---
>> +$id:http://devicetree.org/schemas/rtc/amlogic,amlogic-rtc.yaml#
>> +$schema:http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Amlogic Real Time Clock controller include a4, a5
>> +
>> +maintainers:
>> + - Yiting Deng<yiting.deng at amlogic.com>
>> + - Xianwei Zhao<xianwei.zhao at amlogic.com>
>> +
>> +description:
>> + The Amlogic new chips used RTC module.
>> +
>> +allOf:
>> + - $ref: rtc.yaml#
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - amlogic,a4-rtc
>> + - amlogic,a5-rtc
> The names you have chosen here do not match the patch description. What
> is going on there?
>
Will modify description to "Add Amlogic A4(A311L2) and A5(A113X2) rtc".
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + clocks:
>> + items:
>> + - description: RTC clock source, available 24M or 32K crystal
>> + oscillator source. when using 24M, need to divide 24M into 32K.
>> + - description: RTC module accesses the clock of the apb bus.
>> +
>> + clock-names:
>> + items:
>> + - const: rtc_osc
>> + - const: rtc_sys_clk
> s/_clk//, they're all clocks.
>
Will do.
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> +required:
>> + - compatible
>> + - interrupts
>> + - reg
>> + - clocks
>> + - clock-names
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + apb {
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> +
>> + rtc: rtc at 8e600 {
> And the label here can go, you've got no references to it 🙂
>
Will delte rtc label.
> Thanks,
> Conor.
>
>> + compatible = "amlogic,a4-rtc";
>> + interrupts = <GIC_SPI 131 IRQ_TYPE_EDGE_RISING>;
>> + reg = <0x0 0x8e600 0x0 0x38>;
>> + clocks = <&xtal_32k>, <&clkc_periphs 1>;
>> + clock-names = "rtc_osc", "rtc_sys_clk";
>> + };
>> + };
>>
>> --
>> 2.37.1
More information about the linux-amlogic
mailing list