[PATCH] thermal: amlogic: Fix build failure after conversion to .remove_new()

[Rafael J. Wysocki]

On Fri, Sep 29, 2023 at 8:13 AM Uwe Kleine-König
<u.kleine-koenig at pengutronix.de> wrote:
>
> Commit 88af8b66ffed ("thermal: amlogic: Convert to platform remove
> callback returning void") converted amlogic_thermal_disable() to return
> no value but missed that amlogic_thermal_suspend() makes use of the int
> returned by this function. As amlogic_thermal_disable() returned zero
> unconditionally before, add a return 0 to get the same behaviour as
> before the offending commit.
>
> Fixes: 88af8b66ffed ("thermal: amlogic: Convert to platform remove callback returning void")
> Reported-by: kernel test robot <lkp at intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202309291214.Hjn3gJ94-lkp@intel.com/
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
> Hello,
>
> sorry for not catching that before sending. I don't understand yet what
> was wrong with my testing; I would have bet the series was tested with
> an ARCH=arm64 allmodconfig build. :-\
>
> If you prefer it, feel free to squash this patch into the offending
> commit.

Instead, I've dropped the changes in amlogic_thermal_disable() from that commit.

IMO they are not really related to it, because "remove" is not the
only caller of the above.

Thanks!