[PATCH] mmc: meson-gx: Remove setting of CMD_CFG_ERROR
Jerome Brunet
jbrunet at baylibre.com
Wed Sep 27 00:43:57 PDT 2023
s
On Wed 27 Sep 2023 at 15:25, "Rong.Chen" <Rong.Chen at amlogic.com> wrote:
> From: Rong Chen <rong.chen at amlogic.com>
>
> Setting bit CMD_CFG_ERROR has non effects on previous controllers.
Which previous controllers ? v2, v3 ? Can you list the SoCs please ?
> However, it will cause an IRQ and stop working on latest controllers,
Isn't it desirable to stop on error ? seems like a sane thing to do.
> This bit is used for selecting SG LINK of data address.
> Don't set the bit CMD_CFG_ERROR anymore to resolve this issuse.
I'm not sure I understand the actual issue being resolved.
Could you provide more details please ?
>
> Therefore, remove this setting.
>
> Signed-off-by: Rong Chen <rong.chen at amlogic.com>
> ---
> drivers/mmc/host/meson-gx-mmc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 9837dab096e6..c7c067b9415a 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -801,7 +801,6 @@ static void meson_mmc_start_cmd(struct mmc_host *mmc, struct mmc_command *cmd)
>
> cmd_cfg |= FIELD_PREP(CMD_CFG_CMD_INDEX_MASK, cmd->opcode);
> cmd_cfg |= CMD_CFG_OWNER; /* owned by CPU */
> - cmd_cfg |= CMD_CFG_ERROR; /* stop in case of error */
>
> meson_mmc_set_response_bits(cmd, &cmd_cfg);
More information about the linux-amlogic
mailing list