[PATCH] tty: serial: meson: hard LOCKUP on crtscts mode

pkrasavin at imaqliq.ru pkrasavin at imaqliq.ru
Thu Oct 12 05:35:45 PDT 2023


Hello Dmitry,

----- "Dmitry Rokosov" <ddrokosov at salutedevices.com> писал(а): -----

> Please do not use braces where is single statement. In other words:
> 
> 	if (cflags & CRTSCTS) {
> 		if (port->flags & UPF_HARD_FLOW)
> 			val &= ~AML_UART_TWO_WIRE_EN;
> 		else
> 			termios->c_cflag &= ~CRTSCTS;
> 	} else {
> 		val |= AML_UART_TWO_WIRE_EN;
> 	}


thank you for your note, I will provide v2 without braces.

--
Regards,
Pavel.



More information about the linux-amlogic mailing list