[PATCH V6 2/4] dt-bindings: clock: add Amlogic C3 peripherals clock controller bindings

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Fri Nov 10 05:24:39 PST 2023


On 06/11/2023 09:55, Xianwei Zhao wrote:
> @@ -0,0 +1,237 @@

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.

> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
> +/*
> + * Copyright (c) 2023 Amlogic, Inc. All rights reserved.
> + * Author: Chuan Liu <chuan.liu at amlogic.com>
> + */
> +
> +#ifndef _DT_BINDINGS_CLOCK_AMLOGIC_C3_PERIPHERALS_CLKC_H
> +#define _DT_BINDINGS_CLOCK_AMLOGIC_C3_PERIPHERALS_CLKC_H
> +
> +#define CLKID_PLL_SRC				0
> +#define CLKID_MCLK_PLL_SRC			1
> +#define CLKID_DDR_PLL_SRC			2
> +#define CLKID_DDR_PHY_SRC                       3

Fix the indentation. In all other patchses as well.

Best regards,
Krzysztof




More information about the linux-amlogic mailing list