[PATCH] pwm: pwm-meson: fix handling of period/duty if greater than UINT_MAX

Heiner Kallweit hkallweit1 at gmail.com
Wed May 24 12:11:06 PDT 2023


On 23.05.2023 22:51, Martin Blumenstingl wrote:
> On Mon, May 15, 2023 at 10:32 PM Heiner Kallweit <hkallweit1 at gmail.com> wrote:
>>
>> On 08.05.2023 21:46, Martin Blumenstingl wrote:
>>> On Wed, May 3, 2023 at 9:58 PM Heiner Kallweit <hkallweit1 at gmail.com> wrote:
>>>>
>>>> state->period/duty are of type u64, and if their value is greater than
>>>> UINT_MAX, then the cast to uint will cause problems. Fix this by
>>>> changing the type of the respective local variables to u64.
>>>>
>>>> Fixes: b79c3670e120 ("pwm: meson: Don't duplicate the polarity internally")
>>>> Cc: stable at vger.kernel.org
>>>> Suggested-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
>>>> Signed-off-by: Heiner Kallweit <hkallweit1 at gmail.com>
>>> Reviewed-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
>>
>> Not sure about the process in pwm subsystem: When will these patches make
>> it to linux-next? Because I'd like to submit follow-ups with a dependency
>> only after pending patches have been applied.
> I'm also not sure. Personally I would take all patches that fix the
> existing driver code, bundle them into a series and re-send that
> (collecting all Reviewed-by, etc. along the way). The idea is to make
> Thierry's life easier as he just has to apply the series (no need to
> worry about the patch order, ...).

Sounds like a plan, I think I'll follow this suggestion.



More information about the linux-amlogic mailing list