[PATCH] perf/amlogic: resolve conflict between canvas & pmu

Martin Blumenstingl martin.blumenstingl at googlemail.com
Sat Mar 25 13:54:29 PDT 2023


Hi Marc,

thanks for working on this!

On Thu, Mar 23, 2023 at 5:24 PM Marc Gonzalez <marc.w.gonzalez at free.fr> wrote:
>
> According to S905X2 Datasheet - Revision 07:
>
> DMC_MON area spans 0xff638080-0xff6380c0
> DDR_PLL area spans 0xff638c00-0xff638c34
>
> Round DDR_PLL area size up to 0x40
>
> Fixes: 90cf8e21016f ("arm64: dts: meson: Add DDR PMU node")
This is only partially correct. We also need:
Fixes: 2016e2113d35 ("perf/amlogic: Add support for Amlogic meson G12
SoC DDR PMU driver")

> Signed-off-by: Marc Gonzalez <marc.w.gonzalez at free.fr>
> ---
>  arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 12 ++++++------
>  drivers/perf/amlogic/meson_g12_ddr_pmu.c          | 34 +++++++++++++++++-----------------
I think it makes sense to split this patch into two separate patches,
each of them with the proper Fixes tag attached (and subject prefix).
That way the maintainers of the according files can pick them up (.dts
and driver changes usually go through different trees, I expect this
to be the case here as well).

My understanding is that the driver changes will go through a tree
other than the Amlogic one (I suspect it's Will Deacon's tree).
Please Cc the other maintainers and mailing lists as shown by
scripts/get_maintainer.pl:
  Will Deacon <will at kernel.org> (maintainer:ARM PMU PROFILING AND DEBUGGING)
  Mark Rutland <mark.rutland at arm.com> (maintainer:ARM PMU PROFILING
AND DEBUGGING)
  linux-arm-kernel at lists.infradead.org (moderated list:ARM/Amlogic
Meson SoC support)

The contents of the patch look good to me - so this is only about
organizing things.


Best regards,
Martin



More information about the linux-amlogic mailing list