[PATCH 17/28] media: platform: sun6i-mipi-csi2: drop of_match_ptr for ID table
Paul Kocialkowski
paul.kocialkowski at bootlin.com
Tue Mar 14 09:04:13 PDT 2023
Hi Krzysztof,
On Sun 12 Mar 23, 14:13, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here). This
> also fixes !CONFIG_OF error:
>
> drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:751:34: error: ‘sun6i_mipi_csi2_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
Looks good to me:
Reviewed-by: Paul Kocialkowski <paul.kocialkowski at bootlin.com>
Thanks !
Paul
> ---
> drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c b/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c
> index a220ce849b41..0851b6b4e1ff 100644
> --- a/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c
> +++ b/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c
> @@ -759,7 +759,7 @@ static struct platform_driver sun6i_mipi_csi2_platform_driver = {
> .remove = sun6i_mipi_csi2_remove,
> .driver = {
> .name = SUN6I_MIPI_CSI2_NAME,
> - .of_match_table = of_match_ptr(sun6i_mipi_csi2_of_match),
> + .of_match_table = sun6i_mipi_csi2_of_match,
> .pm = &sun6i_mipi_csi2_pm_ops,
> },
> };
> --
> 2.34.1
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-amlogic/attachments/20230314/e65daa43/attachment.sig>
More information about the linux-amlogic
mailing list